Hey,
After discussion with Robla and DanielK, we (the Wikidata team) decided to write mails to this list now and then complain about our blockers for which we need WMF (or other core dev) assistance :)
Right now we have three patches to core awaiting review:
* https://gerrit.wikimedia.org/r/#/c/14084/
Simple patch, which as far as I can tell is ready to go in. Development of core parts of our phase one functionality is blocked by this, and not having this merged is causing hassle for people that want to setup their own working Wikidata repo-client install.
* https://gerrit.wikimedia.org/r/#/c/14295/
More complex patch, but has no effect on existing code in core yet, so can be merged in without much risk. It's less urgent then the first patch, although it just sitting there is causing overhead in regard to further developing this code, and is preventing us from starting to work on updating core code to make use of this rewrite.
* The Wikidata core branch with ContentHandler stuff
DanielK needs to chime in here, as I was unable to find anything sitting on gerrit waiting for review. In any case, my understanding is that we still need to get quite a bit merged in, doing this step by step, so obviously we can only get to the next one when the current one got merged.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --
On Mon, Jul 23, 2012 at 8:23 PM, Jeroen De Dauw jeroendedauw@gmail.com wrote:
Hey,
After discussion with Robla and DanielK, we (the Wikidata team) decided to write mails to this list now and then complain about our blockers for which we need WMF (or other core dev) assistance :)
Right now we have three patches to core awaiting review:
Simple patch, which as far as I can tell is ready to go in. Development of core parts of our phase one functionality is blocked by this, and not having this merged is causing hassle for people that want to setup their own working Wikidata repo-client install.
More complex patch, but has no effect on existing code in core yet, so can be merged in without much risk. It's less urgent then the first patch, although it just sitting there is causing overhead in regard to further developing this code, and is preventing us from starting to work on updating core code to make use of this rewrite.
- The Wikidata core branch with ContentHandler stuff
DanielK needs to chime in here, as I was unable to find anything sitting on gerrit waiting for review. In any case, my understanding is that we still need to get quite a bit merged in, doing this step by step, so obviously we can only get to the next one when the current one got merged.
I'd like to add one thing: It'd be awesome if Jens Ohlig could get enough gerrit karma to be able to push tags. This way he could create a tag whenever he updates the demo system and it'd be easy to see for people which patches are live on the current demo system and which are not yet.
Cheers Lydia
On Mon, Jul 23, 2012 at 8:36 PM, Lydia Pintscher lydia.pintscher@wikimedia.de wrote:
I'd like to add one thing: It'd be awesome if Jens Ohlig could get enough gerrit karma to be able to push tags. This way he could create a tag whenever he updates the demo system and it'd be easy to see for people which patches are live on the current demo system and which are not yet.
Jeroen just told me that we can do this ourselves after all and gave Jens the necessary rights. Please ignore.
Cheers Lydia
Hi Jeroen,
Thanks for this! Per our conversation, I'd love for this to be weekly, even if the status is "no change". Even that is useful information, since it may uncover cases where we're waiting for each other thinking that the other party has the next step.
More below:
On Mon, Jul 23, 2012 at 11:23 AM, Jeroen De Dauw jeroendedauw@gmail.com wrote:
Right now we have three patches to core awaiting review:
Simple patch, which as far as I can tell is ready to go in. Development of core parts of our phase one functionality is blocked by this, and not having this merged is causing hassle for people that want to setup their own working Wikidata repo-client install.
It looks a little more complicated to me, but I agree that the ball is in our court to provide an alternate design idea. Tim and/or Asher, could you weigh in on this?
More complex patch, but has no effect on existing code in core yet, so can be merged in without much risk. It's less urgent then the first patch, although it just sitting there is causing overhead in regard to further developing this code, and is preventing us from starting to work on updating core code to make use of this rewrite.
I think having this in commits us to a direction, which is why we're being more conservative than you'd hope. This is also getting into an area that Chad has plans to address, so we'd like to make sure that this aligns with our future plans.
- The Wikidata core branch with ContentHandler stuff
DanielK needs to chime in here, as I was unable to find anything sitting on gerrit waiting for review. In any case, my understanding is that we still need to get quite a bit merged in, doing this step by step, so obviously we can only get to the next one when the current one got merged.
I'll talk to Tim about this later today. Tim and/or Daniel, what's the best place to keep up with the latest on your conversation on this branch?
Just looking here: https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/core+bran...
...I would agree with Jeroen that everything looks reviewed and ready to go.
Rob
Hi all
as a follow up to Jeroens mail, I'd like to give a quick overview of things that need to happen before we can roll out phase I of Wikidata on the first Wikipedia (scheduled for "late summer"). As we are approaching feature completeness, it becomes increasingly urgent to have a plan for getting the code deployed. Here's a quick list of stuff we need:
* The most urgent bit is review of the Wikidata branch, which mainly means introducing the ContentHandler facility into core, see below.
* The whole Wikibase code (3 extensions: repo, client and shared code in lib) needs a review (the repo ist the least critical, since it will not be deployed on Wikipedias). It's fairly large and could use a good looking over by anyone who could spare a few minutes. If the code is unclear or confusing, also let us know. I suggest to file any problem you find on bugzilla (in the misleadingly named WikidataRepo or WikidataClient extensions) - got a better idea?
* Before actual deployment, we need to test in a more-like-production environment. Ideally, we would use a Beta-Labs project for this. What's the status of this, what's the procedure for testing a new extension there?
About the Wikidata branch:
On 23.07.2012 20:23, Jeroen De Dauw wrote:
- The Wikidata core branch with ContentHandler stuff
DanielK needs to chime in here, as I was unable to find anything sitting on gerrit waiting for review. In any case, my understanding is that we still need to get quite a bit merged in, doing this step by step, so obviously we can only get to the next one when the current one got merged.
I agreed with Tim that this will be done as a direct merge of the Wikidata branch, so core devs can work on the branch directly without the need to amend patches, etc.
Things got a bit stuck for a bit over the last 4 weeks, because I was busy traveling to Wikimania and having a look at New York. I have picked up work on the branch last week, merged in the latest master and did some refactoring that Tim requested (moved several functions from ContentHandlers to Content).
It would be really helpful to get this review done soon, so we can code the extension against the actual current master. Also, several other projects, like Geodata, could benefit a lot from the ContentHandler stuff.
Note that if all else fails, the Wikidata branch could stay separate and only be deployed on the Wikidata repo wiki. The client Wikis (Wikipedias) don't need it.
Please let us know what we can do support up the review process.
-- daniel
Hi Daniel,
More inline:
On Thu, Jul 26, 2012 at 6:53 AM, Daniel Kinzler daniel@brightbyte.de wrote:
as a follow up to Jeroens mail, I'd like to give a quick overview of things that need to happen before we can roll out phase I of Wikidata on the first Wikipedia (scheduled for "late summer"). As we are approaching feature completeness, it becomes increasingly urgent to have a plan for getting the code deployed. Here's a quick list of stuff we need:
- The most urgent bit is review of the Wikidata branch, which mainly means
introducing the ContentHandler facility into core, see below.
That's filed here: https://bugzilla.wikimedia.org/38622
Assuming Tim doesn't weigh in before we speak, I'll talk to him next week about this.
- The whole Wikibase code (3 extensions: repo, client and shared code in lib)
needs a review (the repo ist the least critical, since it will not be deployed on Wikipedias). It's fairly large and could use a good looking over by anyone who could spare a few minutes. If the code is unclear or confusing, also let us know.
A bug in Bugzilla per extension would be helpful (e.g. "Review the Wikibase repo extension for deployment"). Each bug should have a very brief explanation of what the role of that extension is and a link to the repo.
I imagine the same person will review them all, but we may decide to break it up, so separate bugs would probably be best.
I suggest to file any problem you find on bugzilla (in the misleadingly named WikidataRepo or WikidataClient extensions) - got a better idea?
Sounds reasonable.
- Before actual deployment, we need to test in a more-like-production
environment. Ideally, we would use a Beta-Labs project for this. What's the status of this, what's the procedure for testing a new extension there?
Let's get the core dependencies merged into master first.
About the Wikidata branch: [...] Things got a bit stuck for a bit over the last 4 weeks, because I was busy traveling to Wikimania and having a look at New York. I have picked up work on the branch last week, merged in the latest master and did some refactoring that Tim requested (moved several functions from ContentHandlers to Content).
It would be really helpful to get this review done soon, so we can code the extension against the actual current master. Also, several other projects, like Geodata, could benefit a lot from the ContentHandler stuff.
Thanks for that update. I've copied this info into bug 38622.
Note that if all else fails, the Wikidata branch could stay separate and only be deployed on the Wikidata repo wiki. The client Wikis (Wikipedias) don't need it.
That doesn't help us all that much. Even though we can theoretically deploy many MediaWiki versions now, in practical terms, we can only have 2 or 3 versions of MediaWiki on the production cluster at any given time due to the way APC caching works (currently, all Apache servers run all MediaWiki versions). So, we really need to get the Wikidata branch into master before deploying.
Please let us know what we can do support up the review process.
I've started an activity page here for the Wikidata deployment: http://www.mediawiki.org/wiki/Wikidata_deployment
I put the blockers list on that page. If you'd prefer to keep that list somewhere else (e.g. meta or Bugzilla) that's fine by me as long as it's somewhere we already generally use and have accounts. An updated and complete list of blockers along with a weekly update on the state of that list will help a ton in accelerating this, because that helps me check in with everyone in an organized way.
Thanks Rob
wikitech-l@lists.wikimedia.org