-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
MediaWikiTestCase will now verify[1] that @covers tags are sane when running normal PHPUnit tests. Previously PHPUnit would only verify that when it ran the twice daily coverage job, and fail if even a single one was wrong.
This also affects extensions, even though we don't generate coverage reports for them yet[2]!
If your tests extend the PHPUnit_Framework_TestCase class, you can just add "use MediaWikiCoversValidator" so the trait is invoked and will still validate @covers tags.
[1] https://gerrit.wikimedia.org/r/#/c/399775/ [2] https://phabricator.wikimedia.org/T71685
- -- Legoktm
On Fri, Dec 29, 2017 at 12:47 PM Kunal Mehta legoktm@member.fsf.org wrote:
MediaWikiTestCase will now verify[1] that @covers tags are sane when running normal PHPUnit tests. Previously PHPUnit would only verify that when it ran the twice daily coverage job, and fail if even a single one was wrong.
This also affects extensions, even though we don't generate coverage reports for them yet[2]!
If your tests extend the PHPUnit_Framework_TestCase class, you can just add "use MediaWikiCoversValidator" so the trait is invoked and will still validate @covers tags.
As a friendly reminder: if you don't need all the overhead of MediaWikiTestCase (ie: you're writing actual unit tests that don't depend on MediaWiki), it's encouraged to extend PHPUnit_Framework_TestCase directly. It's wayyyyyy faster.
-Chad
wikitech-l@lists.wikimedia.org