Mean to send this directly to brion, ah well ;D

-Aaron Schulz

From: jschulz_4587@msn.com To: wikitech-l@lists.wikimedia.org Date: Sun, 11 May 2008 09:51:03 -0400 Subject: [Wikitech-l] FlaggedRevs

Can you diff and sync flaggedrevs, then turn it on again? I changed a query so that it uses the PRIMARY index now, where as it was index missing before. Domas disabled the extension since that was piling on table scans of flaggedrevs. Thanks.

-Aaron Schulz

---

Get Free (PRODUCT) RED™ Emoticons, Winks and Display Pics. http://joinred.spaces.live.com?ocid=TXT_HMTG_prodredemoticons_052008 _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_________________________________________________________________ Stay in touch when you're away with Windows Live Messenger. http://www.windowslive.com/messenger/overview.html?ocid=TXT_TAGLM_WL_Refresh...

On May 11, 2008, at 4:53 PM, Aaron Schulz wrote:

Mean to send this directly to brion, ah well ;D

oh, and by the way, just you wouldn't say it was "just one query slipped". The '\n' string at tags looks buggy too :)

mysql> explain -> SELECT /* FlaggedRevs::getStablePageRev ... */ fr_rev_id,fr_page_id,fr_user,fr_timestamp,fr_comment,fr_quality,fr_tags, fr_text,fr_flags FROM `flaggedpages`,`flaggedrevs` WHERE fp_page_id = '2327944' AND (fp_stable = fr_rev_id) LIMIT 1 -> ; +--------------+-------+---------------+---------+---------+------- +--------+-------------+ | table | type | possible_keys | key | key_len | ref | rows | Extra | +--------------+-------+---------------+---------+---------+------- +--------+-------------+ | flaggedpages | const | PRIMARY | PRIMARY | 4 | const | 1 | | | flaggedrevs | ALL | NULL | NULL | NULL | NULL | 131893 | Using where | +--------------+-------+---------------+---------+---------+------- +--------+-------------+ 2 rows in set (0.01 sec)

mysql> SELECT /* FlaggedRevs::getStablePageRev 89.15.146.145 */ fr_rev_id,fr_page_id,fr_user,fr_timestamp,fr_comment,fr_quality,fr_tags, fr_text,fr_flags FROM `flaggedpages`,`flaggedrevs` WHERE fp_page_id = '2327944' AND (fp_stable = fr_rev_id) LIMIT 1 -> ; +-----------+------------+---------+----------------+------------ +------------+--------------+------------------------ +---------------------+ | fr_rev_id | fr_page_id | fr_user | fr_timestamp | fr_comment | fr_quality | fr_tags | fr_text | fr_flags | +-----------+------------+---------+----------------+------------ +------------+--------------+------------------------ +---------------------+ | 45783237 | 2327944 | 32049 | 20080508112117 | | 0 | accuracy:1\n | DB://cluster14/2911910 | utf-8,gzip,external | +-----------+------------+---------+----------------+------------ +------------+--------------+------------------------ +---------------------+ 1 row in set (0.71 sec)