While going through the bugs that were marked as 1.20 tarball blockers today, most seemed to have been left to rot -- that is, they didn't really deserve the tag since people were not motivated to fix them and the people who marked them 1.20 tarball blockers didn't put in the effort to find someone to fix them.
Sometimes, that person was me, so this shouldn't be seen as overly harsh criticism.
I did see a couple of exceptions:
* https://bugzilla.wikimedia.org/38273 -- Tidy occasionally isn't executed
Seems to be happening somewhat regularly since July on different WMF sites. Some effort to track it down has been made, but no solution has been found yet. I've a feeling this bug would bite third-party users of MW if we released a tarball with it.
* https://bugzilla.wikimedia.org/35894 -- Reports of secret key generation "hanging" on windows`
This is a bug that will really affect only new tarball users on Windows. While this probably isn't a lot of people, I would still like to see it fixed before a tarball is released. MaxSem had some ideas and I'll talk to him about how feasibly he can implement them.
Otherwise, there are several patches mostly by Krinkle that need to be merged for a 1.20 tarball:
https://bugzilla.wikimedia.org/31676 - ResourceLoader should work around IE stylesheet limit https://bugzilla.wikimedia.org/38158 - jquery.byteLimit sometimes causes an unexpected 0 maxLength being enforced https://bugzilla.wikimedia.org/40448 - Replace mediawiki.legacy.mwsuggest with SimpleSearch. https://bugzilla.wikimedia.org/40500 - ResourceLoader should not ignore media-type for urls in debug mode https://bugzilla.wikimedia.org/35923 - Followup to bug 11374 - tweaks to mediawiki.action.history.diff.css https://bugzilla.wikimedia.org/40498 - ResourceLoader should not output an empty "@media print { }" block.
I still plan on being in #wikimedia-dev at UTC1100 on Tuesday, October 2 (See [0] for timezone conversion) for the triage, but I'll probably be spending that time putting in merge requests for the above issues (unless someone beats me to it).
Also Tuesday, I'll make a new tarball with the code merged as my final release candidate for 1.20. Sam has said that because we're doing a review-first model with Gerrit people should feel more liberty to put merge requests in, so have at it! [1]
Mark.
[0-short] http://hexm.de/lr [0-long] http://www.timeanddate.com/worldclock/meetingdetails.html?year=2012&month=10&day=2&hour=11&min=0&sec=0&p1=240&p2=44&p3=37&p4=136&p5=179&p6=224
[1-short] http://hexm.de/lw [1-long] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:REL1_20,n,z
I've been pretty busy with other work all week and, as a result, I haven't had time to look at the 1.20 release. On September 30 (2 weeks ago) I sent out a message with what I saw as the blocker bugs at that point.
Only one of those bugs does not yet have any sort of resolution on it.
- https://bugzilla.wikimedia.org/35894 -- Reports of secret key generation "hanging" on windows`
At this point, I think we should add a "known issues" section to the release notes and plan to have a 1.20.1 release with this so that I can put together an RC1 tarball tomorrow for you guys to test.
That said, some bugs have been added to the 1.20.0 milestone, but unless there is a major objection, I'd like to target those to the 1.20.1 release so that we don't hold up the 1.20.0 release any longer. These bugs could be listed in the "known issues" section of the release notes with a statement that we're planning a 1.20.1 release.
And, speaking of plans, I will have time to write up my ideas for a release schedule tomorrow. This will mean plans for future releases as well as support for 1.19 and 1.18.
Mark.
Hi Mark,
Comments inline:
On Fri, Oct 12, 2012 at 7:16 AM, Mark A. Hershberger mah@everybody.org wrote:
At this point, I think we should add a "known issues" section to the release notes and plan to have a 1.20.1 release with this so that I can put together an RC1 tarball tomorrow for you guys to test.
That said, some bugs have been added to the 1.20.0 milestone, but unless there is a major objection, I'd like to target those to the 1.20.1 release so that we don't hold up the 1.20.0 release any longer. These bugs could be listed in the "known issues" section of the release notes with a statement that we're planning a 1.20.1 release.
Yup, that sounds reasonable.
And, speaking of plans, I will have time to write up my ideas for a release schedule tomorrow. This will mean plans for future releases as well as support for 1.19 and 1.18.
Great, thanks for doing this!
Rob
I've put up an rc1 release with the following bit added to the RELEASE-NOTES-1.20 file:
=== Known issues in 1.20.0 === These are issues that we're targeting to be fixed in a later release in the 1.20 series. Issues may be added or removed from this list as we see fit. For now, it is comprised of those bugs on the 1.20.0 milestone in Bugzilla.
* (bug 27202): API: Add timestamp sort to list=allimages * (bug 35894): Reports of secret key generation "hanging" on windows * (bug 37209): LinkCache doesn't currently know about this title * (bug 37714): [Regression] Incomplete log entries * (bug 38334): PHP Notice: Undefined index: href in /www/w/skins/Vector.php on line 416 * (bug 39268): [Regression] Toolbar inserts in main textarea only (instead of the focussed textarea) * (bug 40598): [Regression] jquery.localize tests are failing in IE6-8 * (bug 40632): Kill $wgCleanupPresentationalAttributes from MediaWiki core * (bug 40641): Clicking "others" in Special:Version asks to download a file * (bug 40780): searchsuggest-containing line ("containing...") doesn't include the entered text * (bug 40939): [Regression] InfoAction: Call to a member function getUserText() on a non-object
Full release notes: http://mah.everybody.org/mediawiki/1.20/RELEASE-NOTES-1.20.txt
********************************************************************** Download: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc1.tar.gz
GPG signatures: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc1.tar.gz.sig
Public keys: http://mah.everybody.org/contact-info http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7956EE477F901A30
I think an rc2 is a good idea. The "Known Issues" section of the RELEASE-NOTES-1.20 has shrunk and I've used Platonides comments to update that section so that people can see whether or not they are affected. In any case here is what it looks like (with some editing of my own for this email:
* (bug 35894): Reports of secret key generation "hanging" on windows This is probably a bug that has been fixed in PHP. If you run into this, try upgrading your PHP. * (bug 38334): Undefined index: href in Vector.php on line 416 We think this is a problem in some extension. If you see this, try disabling your extensions and check out the logging patch on this bug. Or try this patch: https://gerrit.wikimedia.org/r/#/c/27937/1/skins/Vector.php * (bug 39268): [Regression] Toolbar inserts in main textarea only This should only be an issue if you are using the ProofreadPage extension. * (bug 40641): Clicking "others" in Special:Version downloads a file If you encounter this, you can tell your webserver to serve the CREDITS file with text/plain MIME type to fix it.
Full release notes: http://mah.everybody.org/mediawiki/1.20/RELEASE-NOTES-1.20.txt
********************************************************************** Download: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.tar.gz
Patch to previous version (1.20.0rc1), without interface text: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.patch.gz Interface text changes: http://mah.everybody.org/mediawiki/1.20/mediawiki-i18n-1.20.0rc2.patch.gz
GPG signatures: http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.tar.gz.sig http://mah.everybody.org/mediawiki/1.20/mediawiki-1.20.0rc2.patch.gz.sig http://mah.everybody.org/mediawiki/1.20/mediawiki-i18n-1.20.0rc2.patch.gz.si...
Public keys: https://mah.everybody.org/contact-info
Mark, thank you, for preparing the RC.
I've started packaging for openSUSE, but after updating my test-system, I have recognized, that everything is very slow now. Where it took MW1.19 ~0.3 secs to render a page, I have now to wait for 12 seconds.
I don't see any issues in the apache-log nor do I see any issues in mediawiki's debug log file. There is no high load on the server and there are no long-lasting database operations. It' just takes a long time to display the site. Also some of the resources loaded via load.php takes around 10 second (namely startup, skins-vector, site, jquery.client and jquery.autoEllipsis. The modules site and mediawiki.legacy.commonPrint for example are loading very fast (100ms).
Does anyone have an idea what's going on here? rolling back to an 1.19 makes everything working normally.
Best regards, Johannes
Am 22.10.2012 00:38, schrieb Mark A. Hershberger:
I think an rc2 is a good idea. The "Known Issues" section of the RELEASE-NOTES-1.20 has shrunk and I've used Platonides comments to update that section so that people can see whether or not they are affected. In any case here is what it looks like (with some editing of my own for this email:
wikitech-l@lists.wikimedia.org