Sometime between yesterday and today, the edit summary field on en.wp's edit page lost its "type=text" attribute. It now reads:
<input name="wpSummary" size="60" value="" id="wpSummary" maxlength="200" tabindex="1" />
Lo and behold, type=text is the default, so it doesn't actually break a standards-compliant browser, but it's kind of an an odd change. (I noticed because it mildly broke a bot of mine, that assumed type=text only by accident, and after printing some extraneous error messages.)
On Wed, Feb 18, 2009 at 7:12 PM, Steve Summit scs@eskimo.com wrote:
Sometime between yesterday and today, the edit summary field on en.wp's edit page lost its "type=text" attribute. It now reads:
<input name="wpSummary" size="60" value="" id="wpSummary" maxlength="200" tabindex="1" />Lo and behold, type=text is the default, so it doesn't actually break a standards-compliant browser, but it's kind of an an odd change. (I noticed because it mildly broke a bot of mine, that assumed type=text only by accident, and after printing some extraneous error messages.)
It was part of some much-needed code cleanup I did to the editing page.
Is it causing any problems?
You should note that bots *should not* be using the UI, as breaking changes such as this. They should use the API which is set up for bots.
Even using the UI, you should use a proper HTML parser, not regexes (as I suspect you were using) to parse the HTML.
-- Andrew Garrett
Andrew Garrett wrote:
On Wed, Feb 18, 2009 at 7:12 PM, Steve Summit scs@eskimo.com wrote:
Sometime between yesterday and today, the edit summary field on en.wp's edit page lost its "type=text" attribute.
Is it causing any problems?
No, just a curiosity.
It was part of some much-needed code cleanup I did to the editing page.
Okay, but beware: wpAntispam still does have the explicit type="text", and there's a confusing welter of single and double quotes among the type='hidden' fields. :-)
You should note that bots *should not* be using the UI, as breaking changes such as this.
Oh, yeah, I know. But it's an old bot, and it mostly works, and I haven't found time to sit down and rewrite it to use the API.
Even using the UI, you should use a proper HTML parser, not regexes (as I suspect you were using) to parse the HTML.
Don't worry, it uses a *ML parser.
Hmmm interesting bit I found when doing a search http://code.google.com/p/google-caja/issues/detail?id=920
Honestly I always considered it proper form coding to always specify the type of the input. I thought I read a few notes on older browsers (Netscape?) not handling inputs without a type= correctly.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://nadir-seen-fire.com] -Nadir-Point (http://nadir-point.com) -Wiki-Tools (http://wiki-tools.com) -MonkeyScript (http://monkeyscript.nadir-point.com) -Animepedia (http://anime.wikia.com) -Narutopedia (http://naruto.wikia.com) -Soul Eater Wiki (http://souleater.wikia.com)
Steve Summit wrote:
Andrew Garrett wrote:
On Wed, Feb 18, 2009 at 7:12 PM, Steve Summit scs@eskimo.com wrote:
Sometime between yesterday and today, the edit summary field on en.wp's edit page lost its "type=text" attribute.
Is it causing any problems?
No, just a curiosity.
It was part of some much-needed code cleanup I did to the editing page.
Okay, but beware: wpAntispam still does have the explicit type="text", and there's a confusing welter of single and double quotes among the type='hidden' fields. :-)
You should note that bots *should not* be using the UI, as breaking changes such as this.
Oh, yeah, I know. But it's an old bot, and it mostly works, and I haven't found time to sit down and rewrite it to use the API.
Even using the UI, you should use a proper HTML parser, not regexes (as I suspect you were using) to parse the HTML.
Don't worry, it uses a *ML parser.
On Fri, Feb 20, 2009 at 3:59 AM, Daniel Friesen dan_the_man@telus.net wrote:
Hmmm interesting bit I found when doing a search http://code.google.com/p/google-caja/issues/detail?id=920
As the bug describes, it seems that application is behaving in a nonstandard fashion.
Honestly I always considered it proper form coding to always specify the type of the input. I thought I read a few notes on older browsers (Netscape?) not handling inputs without a type= correctly.
We don't have to worry about Netscape.
wikitech-l@lists.wikimedia.org