On 26/08/07, aaron@svn.wikimedia.org aaron@svn.wikimedia.org wrote:
Revision: 25152 Author: aaron Date: 2007-08-26 09:49:28 +0000 (Sun, 26 Aug 2007)
Log Message:
*Generalize function to list UI names for all groups with a permission into OutputPage::getGroupsWithPermission() *Make a separate function in article for showing protection notice thingy on view. List out who can edit/move the page. *Some messages added for above. Remove annoying html comment from one. *Fix php array index errors with protection notice
I'd recommend renaming these messages - "subtitle1", "subtitle2" and "subtitle3" don't convey any information about the message's purpose beyond that it's a subtitle, which makes localisation harder, among other things.
Rob Church
Hmm, good idea. I've changed them while it's still easy (not in every other language file yet).
Rob Church wrote:
On 26/08/07, aaron@svn.wikimedia.org aaron@svn.wikimedia.org wrote:
Revision: 25152 Author: aaron Date: 2007-08-26 09:49:28 +0000 (Sun, 26 Aug 2007)
Log Message:
*Generalize function to list UI names for all groups with a permission into OutputPage::getGroupsWithPermission() *Make a separate function in article for showing protection notice thingy on view. List out who can edit/move the page. *Some messages added for above. Remove annoying html comment from one. *Fix php array index errors with protection notice
I'd recommend renaming these messages - "subtitle1", "subtitle2" and "subtitle3" don't convey any information about the message's purpose beyond that it's a subtitle, which makes localisation harder, among other things.
Rob Church
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l
Grrr...fucking commit summary typo ;)
Voice of All wrote:
Hmm, good idea. I've changed them while it's still easy (not in every other language file yet).
Rob Church wrote:
On 26/08/07, aaron@svn.wikimedia.org aaron@svn.wikimedia.org wrote:
Revision: 25152 Author: aaron Date: 2007-08-26 09:49:28 +0000 (Sun, 26 Aug 2007)
Log Message:
*Generalize function to list UI names for all groups with a permission into OutputPage::getGroupsWithPermission() *Make a separate function in article for showing protection notice thingy on view. List out who can edit/move the page. *Some messages added for above. Remove annoying html comment from one. *Fix php array index errors with protection notice
I'd recommend renaming these messages - "subtitle1", "subtitle2" and "subtitle3" don't convey any information about the message's purpose beyond that it's a subtitle, which makes localisation harder, among other things.
Rob Church
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org