aaron@svn.wikimedia.org schrieb:
Revision: 23297 Author: aaron Date: 2007-06-23 17:27:39 +0000 (Sat, 23 Jun 2007)
Log Message:
*Add year/month selector to user contribs (bug 516)
Modified: trunk/phase3/includes/Xml.php
--- trunk/phase3/includes/Xml.php 2007-06-23 15:56:34 UTC (rev 23296) +++ trunk/phase3/includes/Xml.php 2007-06-23 17:27:39 UTC (rev 23297)
- public static function monthSelector($selected = '', $allmonths = null) {
if( is_null( $selected ) )$selected = '';$s = "\n<select id='month' name='month' class='monthselector'>\n";$arr = Language::$mMonthGenMsgs;
Why do you use the genitiv form of monthnames? At least in German it's wrong.
Raymond.
I am not sure what the "genitiv form" is. If there is a bug, then you are welcomed to commit a fix though.
-Aaron Schulz
From: Raimond Spekking raimond.spekking@gmail.com Reply-To: Wikimedia developers wikitech-l@lists.wikimedia.org To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] SVN: [23297] trunk/phase3 Date: Mon, 25 Jun 2007 10:45:44 +0200
aaron@svn.wikimedia.org schrieb:
Revision: 23297 Author: aaron Date: 2007-06-23 17:27:39 +0000 (Sat, 23 Jun 2007)
Log Message:
*Add year/month selector to user contribs (bug 516)
Modified: trunk/phase3/includes/Xml.php
--- trunk/phase3/includes/Xml.php 2007-06-23 15:56:34 UTC (rev 23296) +++ trunk/phase3/includes/Xml.php 2007-06-23 17:27:39 UTC (rev 23297)
- public static function monthSelector($selected = '', $allmonths =
null) {
if( is_null( $selected ) )$selected = '';$s = "\n<select id='month' name='month' class='monthselector'>\n";$arr = Language::$mMonthGenMsgs;Why do you use the genitiv form of monthnames? At least in German it's wrong.
Raymond.
<< signature.asc >>
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l
_________________________________________________________________ Get a preview of Live Earth, the hottest event this summer - only on MSN http://liveearth.msn.com?source=msntaglineliveearthhm
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Aaron Schulz wrote:
I am not sure what the "genitiv form" is. If there is a bug, then you are welcomed to commit a fix though.
-Aaron Schulz
Genitive form is like "in January" in English, which is used in some languages.
Fixed the problem in r23381.
Raimond Spekking wrote:
aaron@svn.wikimedia.org schrieb:
Revision: 23297 Author: aaron Date: 2007-06-23 17:27:39 +0000 (Sat, 23 Jun 2007)
Log Message:
*Add year/month selector to user contribs (bug 516)
Modified: trunk/phase3/includes/Xml.php
--- trunk/phase3/includes/Xml.php 2007-06-23 15:56:34 UTC (rev 23296) +++ trunk/phase3/includes/Xml.php 2007-06-23 17:27:39 UTC (rev 23297)
- public static function monthSelector($selected = '', $allmonths = null) {
if( is_null( $selected ) )$selected = '';$s = "\n<select id='month' name='month' class='monthselector'>\n";$arr = Language::$mMonthGenMsgs;Why do you use the genitiv form of monthnames? At least in German it's wrong.
It's wrong to be using any static property of Language directly. Use an accessor instead -- in this case, $wgLang->getMonthName().
-- Tim Starling
wikitech-l@lists.wikimedia.org