If you have any FIXMEs sitting around in CodeReview, you'll be getting another email from me tonight asking you to fix them.
As a reminder for our experienced developers and an introduction for our new developers, there are two or three things that should be done when you feel you've addressed a FIXME'd revision:
1. Make sure the FIXME'd revision is mentioned in your commit summary. (For example: "re: rXXXX. Fixes whitespace problems"). 2. Change the status of the revision from FIXME back to NEW. 3. Leave a comment in response to the comment that pointed out the problem saying you've addressed it.
The third one item is optional and redundant, but it helps the person who marked the code FIXME to see that you have, indeed, fixed the code. They can then change it's status to "resolved".
DO NOT change your fixme'd revisions to "resolved"! Please, only change them to "new".
And now, to send those emails I promised,
Mark.
On Mon, Aug 15, 2011 at 11:45 PM, Mark A. Hershberger mhershberger@wikimedia.org wrote:
DO NOT change your fixme'd revisions to "resolved"! Please, only change them to "new".
You can't anyway, we finally fixed that.
-Chad
wikitech-l@lists.wikimedia.org