-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/11/2010 20:21, Aryeh Gregor wrote:
On Tue, Nov 9, 2010 at 4:51 AM,
<emmanuel(a)engelhart.org> wrote:
Hi,
FTP external link CSS looks like that:
#bodyContent a.external[href ^="ftp://"],
.link-ftp {
background: url(file_icon.gif) center right no-repeat;
padding: 0 18px;
}
This is so it works correctly for both LTR and RTL. Note the following rules:
/* for rtl wikis */
.rtl #bodyContent a.external {
background-position: left;
padding-right: 0;
}
.rtl a.feedlink {
background-position: right;
padding-right: 16px;
padding-left: 0;
}
/* correction for ltr wikis */
.ltr #bodyContent a.external {
padding-left: 0;
}
This way only one rule is needed for each icon type, not one for LTR
and one for RTL. Notice that the icon widths are different for each
type, so this is the most economical way to do it. Your site is
probably missing the .ltr/.rtl class on the body.
In trunk we've switched to using a script that just swaps left and
right everywhere for RTL, so the rule is instead
#bodyContent a.external[href ^="ftp://"],
.link-ftp {
/* @embed */
background: url(file_icon.gif) center right no-repeat;
padding-right: 18px;
}
Thank you for this explanation, this is perfecly clear now for me.
I will try to find why the .ltr/.rtl classe is not defined for the body
and close the bug report.
with the directions presumably flipped somehow. (By
the resource
loader, I'm guessing? That will cause even more trouble for static
dumps, I guess.)
This is perfectly true, I have discovered that a few days ago. The
DumpHTML extension was "broked" by the introduction of the
resourceLoader. Consequently static pages are missing essential CSS
directives and are not correctly displayed. So we have here a regression.
I hope this will be fixed at the moment the new version of Mediawiki
using the resourceLoader will be rollouted on WMF servers.
Thanks again for your help
Emmanuel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla -
http://enigmail.mozdev.org/
iEYEARECAAYFAkzZobIACgkQn3IpJRpNWtPH4gCfdUeSosrRA2mxoEhbQPUNVee/
qFQAoLEuX0NOXYHHUQG012/NO5I7m2i1
=bycx
-----END PGP SIGNATURE-----