On 21/08/07, nickj@svn.wikimedia.org nickj@svn.wikimedia.org wrote:
$m = array(); preg_match( '!\.(css|js)$!u', $this->mTitle->getText(), $m );
Note that $m would have been initialised on the next line, since preg_match() accepts it as a reference, and PHP will initialise variables passed by reference.
Rob Church
Rob Church wrote:
On 21/08/07, nickj@svn.wikimedia.org nickj@svn.wikimedia.org wrote:
$m = array(); preg_match( '!\.(css|js)$!u', $this->mTitle->getText(), $m );Note that $m would have been initialised on the next line, since preg_match() accepts it as a reference, and PHP will initialise variables passed by reference.
Nick doesn't like it, it makes his Zend static analysis thingy go beep.
-- Tim Starling
$m = array(); preg_match( '!\.(css|js)$!u', $this->mTitle->getText(), $m );Note that $m would have been initialised on the next line, since preg_match() accepts it as a reference, and PHP will initialise variables passed by reference.
Nick doesn't like it, it makes his Zend static analysis thingy go beep.
Indeed ;-)
Declaring the 3rd parameter to preg_match() is definitely not required, it's just marginally more explicit, and it means that when the tool is run next it's slightly easier to locate the real problems (usually less than 5 but more than zero) amongst all the noise. But it's a very borderline thing though - and if you object to it, you're most welcome to remove it.
-- All the best, Nick.
wikitech-l@lists.wikimedia.org