-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

brion@svn.wikimedia.org wrote:

Revert r26056 for the moment -- schema change which I don't want to have to run around and apply this second

[snip]

• # Limit cap made to stop nasty timeouts
  

• $sql = "SELECT cuc_ip, cuc_timestamp 
  

• 	FROM $cu_changes FORCE INDEX(cuc_user_time) WHERE cuc_user = $user_id 
  

• 	ORDER BY cuc_timestamp DESC LIMIT 5000";
  

Note also that the schema change wasn't back-compatible; after applying the schema change, the cuc_user_time index would be removed, breaking the old code above which would continue running until all schema changes were applied everywhere and the code update got applied as well.

As much as possible, schema updates should apply cleanly onto old code without breaking, for maximum flexibility in painless upgrades.

- -- brion vibber (brion @ wikimedia.org)