On Thu, Jun 19, 2008 at 2:00 PM, brion@svn.wikimedia.org wrote:

Log Message:

Revert r36273: The change was described only as "Fix confused code", but it changed from something that appears to make sense (check for a permission key for that restriction group) to something that doesn't (hardcoded check for two particular names).

If the change has an effect, and there's a reason for it, please describe it in a bit more detail.

The point that was brought up is that except for in the special case of 'sysop', protection levels are rights, not groups. It makes no sense to check $wgGroupPermissions[$restrictions]; if it exists, it's only by accident, because a group happens to have the same name as the permission being checked for.