Hi, I had to switch computers the other day, which resulted in my having to reinstall git-review, and now it... doesn't work. Basically there are two problems: for every new repository I use, I now need to add a commit-msg hook to the .git directory, and also ssh doesn't work at all, so I have to use https login every time.
Does anyone know how to fix either of these? They are both incredibly annoying and make it borderline unusable (in particular because I have no idea what my password is).
Thanks.
-I
On 23/09/14 00:26, Isarra Yos wrote:
Hi, I had to switch computers the other day, which resulted in my having to reinstall git-review, and now it... doesn't work. Basically there are two problems: for every new repository I use, I now need to add a commit-msg hook to the .git directory, and also ssh doesn't work at all, so I have to use https login every time.
Does anyone know how to fix either of these? They are both incredibly annoying and make it borderline unusable (in particular because I have no idea what my password is).
Apparently I spoke too soon - authentication fails with https too. So it really is unusable.
-I
On 23/09/14 00:34, Isarra Yos wrote:
On 23/09/14 00:26, Isarra Yos wrote:
Hi, I had to switch computers the other day, which resulted in my having to reinstall git-review, and now it... doesn't work. Basically there are two problems: for every new repository I use, I now need to add a commit-msg hook to the .git directory, and also ssh doesn't work at all, so I have to use https login every time.
Does anyone know how to fix either of these? They are both incredibly annoying and make it borderline unusable (in particular because I have no idea what my password is).
Apparently I spoke too soon - authentication fails with https too. So it really is unusable.
-I
For the first one, it may be relevant that all the repositories I've tried so far are submodules, and the .git in those is just a symbolic link to a subdirectory of the .git in the parent repository. I've been dumping the hook in the hooks/ in there.
On 23 Sep 2014 02:34, "Isarra Yos" zhorishna@gmail.com wrote:
Apparently I spoke too soon - authentication fails with https too. So it really is unusable.
Please note that the https password is *not* your normal wikitech password, but rather an application-specific password; you can find it under https://gerrit.wikimedia.org/r/#/settings/http-password .
On 9/23/14, Merlijn van Deen valhallasw@arctus.nl wrote:
On 23 Sep 2014 02:34, "Isarra Yos" zhorishna@gmail.com wrote:
Apparently I spoke too soon - authentication fails with https too. So it really is unusable.
Please note that the https password is *not* your normal wikitech password, but rather an application-specific password; you can find it under https://gerrit.wikimedia.org/r/#/settings/http-password . _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Oh cool. I always assumed that access via https password was just totally broken.
For accessing the git server, you should check that 1) "git remote show origin" (or "git remote show gerrit" - depends on your git-review version + config) returns ssh://<gerrit user>@ gerrit.wikimedia.org:29418/<project name> as the push & fetch URL 2) "ssh -p 29418 <gerrit user>@gerrit.wikimedia.org" returns something like "Welcome to Gerrit Code Review"
If the first does not work, there are problems with your git-review config (maybe check the [gitreview] section in your ~/.gitconfig). If the second does not work, ssh authentication is not set up correctly (key forwarding is not enabled or the right key is not available). This could also be the reason for the hook not working as git-review tries to load it via scp.
On Tue, Sep 23, 2014 at 2:26 AM, Isarra Yos zhorishna@gmail.com wrote:
Hi, I had to switch computers the other day, which resulted in my having to reinstall git-review, and now it... doesn't work. Basically there are two problems: for every new repository I use, I now need to add a commit-msg hook to the .git directory, and also ssh doesn't work at all, so I have to use https login every time.
Does anyone know how to fix either of these? They are both incredibly annoying and make it borderline unusable (in particular because I have no idea what my password is).
Thanks.
-I
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On 23/09/14 08:25, Gergo Tisza wrote:
For accessing the git server, you should check that
- "git remote show origin" (or "git remote show gerrit" - depends on your
git-review version + config) returns ssh://<gerrit user>@ gerrit.wikimedia.org:29418/<project name> as the push & fetch URL 2) "ssh -p 29418 <gerrit user>@gerrit.wikimedia.org" returns something like "Welcome to Gerrit Code Review"
If the first does not work, there are problems with your git-review config (maybe check the [gitreview] section in your ~/.gitconfig). If the second does not work, ssh authentication is not set up correctly (key forwarding is not enabled or the right key is not available). This could also be the reason for the hook not working as git-review tries to load it via scp.
My git-review config hasn't changed. Nothing has changed, that I know of, except the version of git-review I have installed.
The problems, however, seem to mostly just be with submodules, which is a problem for me because basically everything I do is in submodules. As I understand it, the remotes for the submodules are all set in the parent repository's configuration, and thus will always be the same regardless of how you dowloaded or set up the parent. This is just a guess, mind, but I used ssh to download the extensions repo, the remotes for that are ssh, but the submodule remotes are all https. The weird thing is that apparently git review just used to work with this and automatically translated the submodule remotes depending on what the remotes for the parent were. Now it seems like it's too stupid and I have to manually change all the submodule remotes before I can use them?
git review -s also doesn't seem to do anything, so I also have to run a bash script jeremyb sent me (http://paste.debian.net/plain/122534). For every one.
Does this seem right? Has anyone else running the current version run into problems with this? Is there any less tedious way to fix this?
...is there any way to downgrade git-review?
-I
On Tue, Sep 23, 2014 at 8:29 PM, Isarra Yos zhorishna@gmail.com wrote:
As I understand it, the remotes for the submodules are all set in the parent repository's configuration, and thus will always be the same regardless of how you dowloaded or set up the parent.
I don't think that's the case. If you use git submodule init, the remote URLs in the .gitmodules file of the parent will be set as remotes of the children. If you don't use that command, and set up the subdirs manually, the remotes will be whatever you set up.
The weird thing is that apparently git review just used to work with this and automatically translated the submodule remotes depending on what the remotes for the parent were. Now it seems like it's too stupid and I have to manually change all the submodule remotes before I can use them?
AFAIK it just uses whichever remote is called "gerrit". Maybe you changed the name of the default remote some time ago and now that you updated git-review that change took effect? Check out this thread: http://wikimedia.7.x6.nabble.com/New-git-review-lets-you-configure-origin-as...
git review -s also doesn't seem to do anything, so I also have to run a bash script jeremyb sent me (http://paste.debian.net/plain/122534). For every one.
You can use git submodule foreach to run a script for each submodule.
...is there any way to downgrade git-review?
If you installed it via pip, you can try pip install git-review==<version>
On 23/09/14 21:13, Gergo Tisza wrote:
On Tue, Sep 23, 2014 at 8:29 PM, Isarra Yos zhorishna@gmail.com wrote:
As I understand it, the remotes for the submodules are all set in the parent repository's configuration, and thus will always be the same regardless of how you dowloaded or set up the parent.
I don't think that's the case. If you use git submodule init, the remote URLs in the .gitmodules file of the parent will be set as remotes of the children. If you don't use that command, and set up the subdirs manually, the remotes will be whatever you set up.
I did that long ago, before I even installed git-review. Only actually checked what the remotes were now, though.
But they won't do ssh unless I specifically tell them. Is git submodule init supposed to be smart enough for that?
The weird thing is that apparently git review just used to work with this and automatically translated the submodule remotes depending on what the remotes for the parent were. Now it seems like it's too stupid and I have to manually change all the submodule remotes before I can use them?
AFAIK it just uses whichever remote is called "gerrit". Maybe you changed the name of the default remote some time ago and now that you updated git-review that change took effect? Check out this thread: http://wikimedia.7.x6.nabble.com/New-git-review-lets-you-configure-origin-as...
gerrit is set to use origin, but...
git review -s also doesn't seem to do anything, so I also have to run a bash script jeremyb sent me (http://paste.debian.net/plain/122534). For every one.
You can use git submodule foreach to run a script for each submodule.
...is there any way to downgrade git-review?
If you installed it via pip, you can try pip install git-review==<version>
Thank you bunches. Switching to git-review 1.21 seems to have fixed it.
-I
wikitech-l@lists.wikimedia.org