Few initialization / can-we-delete-this questions, if anyone can shed any light on them:
-------------------------------------------
Line 2136 of includes/User.php, $expiration is not defined: $url = $this->confirmationTokenUrl( $expiration );
-------------------------------------------
Line 427 of inclides\MimeMagic.php, $script does not seem to be used, so can this line be deleted? : if (preg_match('%/?([^\s]+/)(w+)%sim',$head,$match)) $script= $match[2];
-------------------------------------------
Line 59 of includes/SpecialRecentChanges.php - $options is not defined, and doesn't seem to be used, so any reason to keep this: # As a feed, use limited settings only if( $feedFormat ) { global $wgFeedLimit; if( $limit > $wgFeedLimit ) { $options['limit'] = $wgFeedLimit; }
}
-------------------------------------------
Line 652 of includes\ImagePage.php, any reason to keep this, as $size does not seem to be used: $dbr =& wfGetDB( DB_SLAVE ); $size = $dbr->selectField( 'oldimage', 'oi_size', array( 'oi_archive_name' => $oldimage ) );
-------------------------------------------
Line 75 of includes\SpecialRevisiondelete.php, any reason this line can't be deleted, as $bitfields isn't used or declared : $bitfields[] = $rev->mDeleted; // FIXME
-------------------------------------------
All the best, Nick.
wikitech-l@lists.wikimedia.org