On Mon, Apr 14, 2008 at 9:37 PM, werdna@svn.wikimedia.org wrote:
Log Message:
Fix up GlobalBlocking::purgeExpired()
$dbw->delete( 'globalblocks', 'gb_expiry<'.$dbw->addQuotes($dbw->timestamp()), __METHOD__ );
$dbw->delete( 'globalblocks', array('gb_expiry<'.$dbw->addQuotes($dbw->timestamp())), __METHOD__ );
What's the difference? These do the same thing, don't they?
On Wed, Apr 16, 2008 at 12:54 AM, Simetrical Simetrical+wikilist@gmail.com wrote:
On Mon, Apr 14, 2008 at 9:37 PM, werdna@svn.wikimedia.org wrote:
Log Message:
Fix up GlobalBlocking::purgeExpired()
$dbw->delete( 'globalblocks', 'gb_expiry<'.$dbw->addQuotes($dbw->timestamp()), __METHOD__ );
$dbw->delete( 'globalblocks', array('gb_expiry<'.$dbw->addQuotes($dbw->timestamp())), __METHOD__ );What's the difference? These do the same thing, don't they?
One spews PHP warnings and does nothing, the other purges expired global blocks from the database.
On Wed, Apr 16, 2008 at 4:47 AM, Andrew Garrett andrew@epstone.net wrote:
One spews PHP warnings and does nothing, the other purges expired global blocks from the database.
It seems Database::makeList insists on getting an array, and won't accept a string. Seems kind of silly.
wikitech-l@lists.wikimedia.org