Ok, last attempt.
This needs merge: https://gerrit.wikimedia.org/r/#/c/151370/
Somebody shat on it (-2), so it looks ugly, sorry for that. Didn't come back to clean up their mess, either, instead told me to advertise it here.
Sorry for putting it like this, in particular with the Sumana's thread right next to it, but really, I am fed up. The way this went lets all that clamoring for contributors sound rather hollow, to my ears at least - they are quite obviously not welcome. I mean being ignored because everybody is apparently super busy is one thing. But being made to jump through hoop after hoop for weeks and then being ignored does feel less like being ignored and more like being made fun of. It will be a long time until I waste my time again on trying to get some patch merged.
Stephan
Please don't feel bad when a patch doesn't make it through, I'm not very familiar with the progress of this particular patch but it happens regularly. I work full time with mediawiki and If you search gerrit for 'owner:"EBernhardson ebernhardson@wikimedia.org" status:abandoned' You will find just shy of 100 patches over a year and a half that didn't make it in. I also have about 750 patches that did get merged in that timeframe.
I'm just trying to say, don't get frustrated. These things happen. I can't comment too much on this particular patch.
Erik B.
On Fri, Sep 12, 2014 at 12:04 PM, Stephan Gambke s7eph4n@gmail.com wrote:
Ok, last attempt.
This needs merge: https://gerrit.wikimedia.org/r/#/c/151370/
Somebody shat on it (-2), so it looks ugly, sorry for that. Didn't come back to clean up their mess, either, instead told me to advertise it here.
Sorry for putting it like this, in particular with the Sumana's thread right next to it, but really, I am fed up. The way this went lets all that clamoring for contributors sound rather hollow, to my ears at least - they are quite obviously not welcome. I mean being ignored because everybody is apparently super busy is one thing. But being made to jump through hoop after hoop for weeks and then being ignored does feel less like being ignored and more like being made fun of. It will be a long time until I waste my time again on trying to get some patch merged.
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Fri, Sep 12, 2014 at 12:04 PM, Stephan Gambke s7eph4n@gmail.com wrote:
Ok, last attempt.
This needs merge: https://gerrit.wikimedia.org/r/#/c/151370/
Somebody shat on it (-2), so it looks ugly, sorry for that. Didn't come back to clean up their mess, either, instead told me to advertise it here.
-2 applied to an old version and was not applicable. I removed it.
Sorry for putting it like this, in particular with the Sumana's thread right next to it, but really, I am fed up. The way this went lets all that clamoring for contributors sound rather hollow, to my ears at least - they are quite obviously not welcome. I mean being ignored because everybody is apparently super busy is one thing. But being made to jump through hoop after hoop for weeks and then being ignored does feel less like being ignored and more like being made fun of. It will be a long time until I waste my time again on trying to get some patch merged.
+2'd. Will be merged shortly when Jenkins does its thing.
-Chad
Stephan, thank you for speaking up. It's incredibly frustrating and demoralizing when you work really hard on a gift (all volunteer contributions are gifts) and you just hear nothing back, or maybe just criticism with not even a thank-you. I'm sorry that this happened to you, that out of dozens of comments, nearly none even explicitly acknowledged and appreciated your effort, and that you had long stretches where you were waiting for a response.
It is absolutely your right to take a break from the frustrations of this project and especially from the abrasions of our code review process. I hope you come back, though, and I hope the Wikimedia technical community makes it appealing for you to come back.
Sumana Harihareswara Senior Technical Writer Wikimedia Foundation
On Fri, Sep 12, 2014 at 3:04 PM, Stephan Gambke s7eph4n@gmail.com wrote:
Ok, last attempt.
This needs merge: https://gerrit.wikimedia.org/r/#/c/151370/
Somebody shat on it (-2), so it looks ugly, sorry for that. Didn't come back to clean up their mess, either, instead told me to advertise it here.
Sorry for putting it like this, in particular with the Sumana's thread right next to it, but really, I am fed up. The way this went lets all that clamoring for contributors sound rather hollow, to my ears at least - they are quite obviously not welcome. I mean being ignored because everybody is apparently super busy is one thing. But being made to jump through hoop after hoop for weeks and then being ignored does feel less like being ignored and more like being made fun of. It will be a long time until I waste my time again on trying to get some patch merged.
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Le 25/09/2014 02:12, Sumana Harihareswara a écrit :
Stephan, thank you for speaking up. It's incredibly frustrating and demoralizing when you work really hard on a gift (all volunteer contributions are gifts) and you just hear nothing back, or maybe just criticism with not even a thank-you. I'm sorry that this happened to you, that out of dozens of comments, nearly none even explicitly acknowledged and appreciated your effort, and that you had long stretches where you were waiting for a response.
It is absolutely your right to take a break from the frustrations of this project and especially from the abrasions of our code review process. I hope you come back, though, and I hope the Wikimedia technical community makes it appealing for you to come back.
The code review worked just fine on https://gerrit.wikimedia.org/r/#/c/151370/
I am the one that stuck a -2 on the patch #13 because it had a ton of duplicate code, no test and a potentially nasty magic method (__call).
Since we disagreed, I asked for the issue to be raised on wikitech-l to attract more folks which eventually led to the bad patch being abandoned in favour of an earlier (and good) one.
Meanwhile, I agree we should be faster on reviewing code but it is not that easy given the amount of patches being received, some proposing fix for very nasty bugs in complicated code paths (which make those patches even more awesome).
Anyway, thanks Stephan for the fix up :-]
wikitech-l@lists.wikimedia.org