Hi all, I'm trying to create a fix for the above mentioned bug. But I have some doubts about the description. It says to change the date format "dd mm" to "dd-mm". So the only change needed is to add a hyphen if there is a date and then a month? (Other than the decimal point change). I have already fixed the bug according to what I have understood (which is mentioned above). Please explain me how to push it to the github (I found the instructions in [1]. Relevant project name and the needed branch name is what I want. Or is there any other way to submit the patch?)
[1]https://gerrit.wikimedia.org/r/Documentation/user-upload.html
Hi,
You can find details of how to submit a patch in [1] and how to link your patch to the bug in [2].
[1]. http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change [2].http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
Thank you,
-Himeshi
On Thu, Mar 13, 2014 at 11:10 AM, Maduranga Siriwardena < maduranga.siriwardena@gmail.com> wrote:
Hi all, I'm trying to create a fix for the above mentioned bug. But I have some doubts about the description. It says to change the date format "dd mm" to "dd-mm". So the only change needed is to add a hyphen if there is a date and then a month? (Other than the decimal point change). I have already fixed the bug according to what I have understood (which is mentioned above). Please explain me how to push it to the github (I found the instructions in [1]. Relevant project name and the needed branch name is what I want. Or is there any other way to submit the patch?)
[1]https://gerrit.wikimedia.org/r/Documentation/user-upload.html
-- Maduranga Siriwardena Undergraduate University of Moratuwa, Faculty of Engineering Department of Computer Science and Engineering _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi, I'm having some trouble when trying to upload the fix to gerrit. I followed the instructions in [1]. But I get the bellow error when trying to run git review -s
Error.
Problems encountered installing commit-msg hook The following command failed with exit code 1 "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg" ----------------------- .git/hooks/commit-msg: No such file or directory -----------------------
[1] http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
On Thu, Mar 13, 2014 at 11:41 AM, Himeshi De Silva himeshidslv@gmail.comwrote:
Hi,
You can find details of how to submit a patch in [1] and how to link your patch to the bug in [2].
[1]. http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change [2].http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
Thank you,
-Himeshi
On Thu, Mar 13, 2014 at 11:10 AM, Maduranga Siriwardena < maduranga.siriwardena@gmail.com> wrote:
Hi all, I'm trying to create a fix for the above mentioned bug. But I have some doubts about the description. It says to change the date format "dd mm"
to
"dd-mm". So the only change needed is to add a hyphen if there is a date and then a month? (Other than the decimal point change). I have already fixed the bug according to what I have understood (which
is
mentioned above). Please explain me how to push it to the github (I found the instructions in [1]. Relevant project name and the needed branch name is what I want. Or is there any other way to submit the patch?)
[1]https://gerrit.wikimedia.org/r/Documentation/user-upload.html
-- Maduranga Siriwardena Undergraduate University of Moratuwa, Faculty of Engineering Department of Computer Science and Engineering _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Let me apologize right now on Gerrit's behalf and on behalf of git-review. They are finicky tools and annoying to set up. Right now, I suggest you instead use this lovely little web app
https://tools.wmflabs.org/gerrit-patch-uploader/
that will upload the patch into Gerrit on your behalf.
Sumana Harihareswara Engineering Community Manager Wikimedia Foundation
On Thu, Mar 13, 2014 at 4:05 AM, Maduranga Siriwardena < maduranga.siriwardena@gmail.com> wrote:
Hi, I'm having some trouble when trying to upload the fix to gerrit. I followed the instructions in [1]. But I get the bellow error when trying to run git review -s
Error.
Problems encountered installing commit-msg hook The following command failed with exit code 1 "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg"
.git/hooks/commit-msg: No such file or directory
[1] http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
On Thu, Mar 13, 2014 at 11:41 AM, Himeshi De Silva <himeshidslv@gmail.com
wrote:
Hi,
You can find details of how to submit a patch in [1] and how to link your patch to the bug in [2].
[1].
http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
[2].http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
Thank you,
-Himeshi
On Thu, Mar 13, 2014 at 11:10 AM, Maduranga Siriwardena < maduranga.siriwardena@gmail.com> wrote:
Hi all, I'm trying to create a fix for the above mentioned bug. But I have some doubts about the description. It says to change the date format "dd mm"
to
"dd-mm". So the only change needed is to add a hyphen if there is a
date
and then a month? (Other than the decimal point change). I have already fixed the bug according to what I have understood (which
is
mentioned above). Please explain me how to push it to the github (I
found
the instructions in [1]. Relevant project name and the needed branch
name
is what I want. Or is there any other way to submit the patch?)
[1]https://gerrit.wikimedia.org/r/Documentation/user-upload.html
-- Maduranga Siriwardena Undergraduate University of Moratuwa, Faculty of Engineering Department of Computer Science and Engineering _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Maduranga Siriwardena Undergraduate University of Moratuwa, Faculty of Engineering Department of Computer Science and Engineering _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi, I'm having some trouble when trying to upload the fix to gerrit. I followed the instructions in [1]. But I get the bellow error when trying to run git review -s
Error.
Problems encountered installing commit-msg hook The following command failed with exit code 1 "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg"
.git/hooks/commit-msg: No such file or directory
[1] http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
I'm certainly no fan of gerrit, and I hope gerrit-patch-uploader that Sumana mentioned helps you. But if not, the error you're having above sounds like you are doing "git review -s" outside your repository's directory. So you might try:
git clone repository-address folder-to-clone-into cd folder-to-clone-into git review -s
I corrected the error by renaming the commit-msg.sample to commit-msg located in .git/hooks/ of the project folder.
On Thu, Mar 13, 2014 at 5:22 PM, Dan Andreescu dandreescu@wikimedia.orgwrote:
Hi, I'm having some trouble when trying to upload the fix to gerrit. I
followed
the instructions in [1]. But I get the bellow error when trying to run git review -s
Error.
Problems encountered installing commit-msg hook The following command failed with exit code 1 "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg"
.git/hooks/commit-msg: No such file or directory
[1]
http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
I'm certainly no fan of gerrit, and I hope gerrit-patch-uploader that Sumana mentioned helps you. But if not, the error you're having above sounds like you are doing "git review -s" outside your repository's directory. So you might try:
git clone repository-address folder-to-clone-into cd folder-to-clone-into git review -s _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
By mistake I uploaded a patch to a bug to Gerrit having some mistakes in the commit message. If I'm linking a bug to the patch I should add Bug: bugnumber But I added it as Bug:bugnumber (Having no space after the colon) Will it be fine for this time? Or should I do something to correct it?
On Thu, Mar 13, 2014 at 5:33 PM, Maduranga Siriwardena < maduranga.siriwardena@gmail.com> wrote:
I corrected the error by renaming the commit-msg.sample to commit-msg located in .git/hooks/ of the project folder.
On Thu, Mar 13, 2014 at 5:22 PM, Dan Andreescu dandreescu@wikimedia.orgwrote:
Hi, I'm having some trouble when trying to upload the fix to gerrit. I
followed
the instructions in [1]. But I get the bellow error when trying to run git review -s
Error.
Problems encountered installing commit-msg hook The following command failed with exit code 1 "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg"
.git/hooks/commit-msg: No such file or directory
[1]
http://www.mediawiki.org/wiki/Gerrit/Tutorial#Make_and_commit_your_change
I'm certainly no fan of gerrit, and I hope gerrit-patch-uploader that Sumana mentioned helps you. But if not, the error you're having above sounds like you are doing "git review -s" outside your repository's directory. So you might try:
git clone repository-address folder-to-clone-into cd folder-to-clone-into git review -s _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Maduranga Siriwardena Undergraduate University of Moratuwa, Faculty of Engineering Department of Computer Science and Engineering
On Mar 13, 2014 2:37 PM, "Maduranga Siriwardena" < maduranga.siriwardena@gmail.com> wrote:
By mistake I uploaded a patch to a bug to Gerrit having some mistakes in the commit message. If I'm linking a bug to the patch I should add Bug: bugnumber But I added it as Bug:bugnumber (Having no space after the colon) Will it be fine for this time? Or should I do something to correct it?
You can send an amended changeset with the same change-id as the original or edit from the gerrit web interface (gerrit will then generate a commit for you)
-Jeremy
Thank you. I edited it from gerrit web interface.
On Fri, Mar 14, 2014 at 12:19 AM, Jeremy Baron jeremy@tuxmachine.comwrote:
On Mar 13, 2014 2:37 PM, "Maduranga Siriwardena" < maduranga.siriwardena@gmail.com> wrote:
By mistake I uploaded a patch to a bug to Gerrit having some mistakes in the commit message. If I'm linking a bug to the patch I should add Bug: bugnumber But I added it as Bug:bugnumber (Having no space after the colon) Will it be fine for this time? Or should I do something to correct it?
You can send an amended changeset with the same change-id as the original or edit from the gerrit web interface (gerrit will then generate a commit for you)
-Jeremy _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org