On Wed, Aug 27, 2008 at 8:04 PM, catrope@svn.wikimedia.org wrote:
Revision: 40116 Author: catrope Date: 2008-08-28 00:04:57 +0000 (Thu, 28 Aug 2008)
Log Message:
(bug 13471) Added NUMBERINGROUP magic word. Patch by Soxred93
Modified Paths:
trunk/phase3/CREDITS trunk/phase3/RELEASE-NOTES trunk/phase3/includes/MagicWord.php trunk/phase3/includes/parser/CoreParserFunctions.php trunk/phase3/languages/messages/MessagesEn.php
Modified: trunk/phase3/CREDITS
--- trunk/phase3/CREDITS 2008-08-27 23:57:54 UTC (rev 40115) +++ trunk/phase3/CREDITS 2008-08-28 00:04:57 UTC (rev 40116) @@ -42,6 +42,7 @@
- Max Semenik
- Mormegil
- RememberTheDot
+* Soxred93
== Translators ==
- Anders Wegge Jakobsen
Modified: trunk/phase3/RELEASE-NOTES
--- trunk/phase3/RELEASE-NOTES 2008-08-27 23:57:54 UTC (rev 40115) +++ trunk/phase3/RELEASE-NOTES 2008-08-28 00:04:57 UTC (rev 40116) @@ -99,6 +99,7 @@
- Backend upload code has been removed from SpecialUpload.php. This may cause
backwards incompatibility with upload extensions.
- BMP images are now displayed as PNG
+* (bug 13471) Added NUMBERINGROUP magic word
=== Bug fixes in 1.14 ===
Modified: trunk/phase3/includes/MagicWord.php
--- trunk/phase3/includes/MagicWord.php 2008-08-27 23:57:54 UTC (rev 40115) +++ trunk/phase3/includes/MagicWord.php 2008-08-28 00:04:57 UTC (rev 40116) @@ -107,6 +107,7 @@ 'pagesincategory', 'index', 'noindex',
'numberingroup', ); /* Array of caching hints for ParserCache */
@@ -145,6 +146,7 @@ 'localtimestamp' => 3600, 'pagesinnamespace' => 3600, 'numberofadmins' => 3600,
'numberingroup' => 3600, ); static public $mDoubleUnderscoreIDs = array(
Modified: trunk/phase3/includes/parser/CoreParserFunctions.php
--- trunk/phase3/includes/parser/CoreParserFunctions.php 2008-08-27 23:57:54 UTC (rev 40115) +++ trunk/phase3/includes/parser/CoreParserFunctions.php 2008-08-28 00:04:57 UTC (rev 40116) @@ -33,6 +33,7 @@ $parser->setFunctionHook( 'numberofarticles', array( __CLASS__, 'numberofarticles' ), SFH_NO_HASH ); $parser->setFunctionHook( 'numberoffiles', array( __CLASS__, 'numberoffiles' ), SFH_NO_HASH ); $parser->setFunctionHook( 'numberofadmins', array( __CLASS__, 'numberofadmins' ), SFH_NO_HASH );
$parser->setFunctionHook( 'numberingroup', array( __CLASS__, 'numberingroup' ), SFH_NO_HASH ); $parser->setFunctionHook( 'numberofedits', array( __CLASS__, 'numberofedits' ), SFH_NO_HASH ); $parser->setFunctionHook( 'language', array( __CLASS__, 'language' ), SFH_NO_HASH ); $parser->setFunctionHook( 'padleft', array( __CLASS__, 'padleft' ), SFH_NO_HASH );
@@ -224,6 +225,9 @@ static function pagesinnamespace( $parser, $namespace = 0, $raw = null ) { return self::formatRaw( SiteStats::pagesInNs( intval( $namespace ) ), $raw ); }
static function numberingroup( $parser, $name = '', $raw = null) {
return self::formatRaw( SiteStats::numberingroup( strtolower( $name ) ), $raw );
} /** * Return the number of pages in the given category, or 0 if it's nonexis-
Modified: trunk/phase3/languages/messages/MessagesEn.php
--- trunk/phase3/languages/messages/MessagesEn.php 2008-08-27 23:57:54 UTC (rev 40115) +++ trunk/phase3/languages/messages/MessagesEn.php 2008-08-28 00:04:57 UTC (rev 40116) @@ -342,6 +342,7 @@ 'pagesize' => array( 1, 'PAGESIZE' ), 'index' => array( 1, '__INDEX__' ), 'noindex' => array( 1, '__NOINDEX__' ),
'numberingroup' => array( 1, 'NUMBERINGROUP', 'NUMINGROUP' ), 'staticredirect' => array( 1, '__STATICREDIRECT__' ),
);
MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
I see you used my SiteStats::numberingroup() method I introduced about a month back. While this is ok for most things, couldn't something like {{numberingroup:rollbacker}} get kind of expensive on a site like enwiki?
-Chad
On Wed, Aug 27, 2008 at 8:44 PM, Chad innocentkiller@gmail.com wrote:
I see you used my SiteStats::numberingroup() method I introduced about a month back. While this is ok for most things, couldn't something like {{numberingroup:rollbacker}} get kind of expensive on a site like enwiki?
Yes, since there's no persistent caching. But "kind of expensive" here means "well under a second". Storing the value in memcached would make it considerably more reasonable, performance-wise. It probably won't be used on many pages anyway.
wikitech-l@lists.wikimedia.org