-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
aaron@svn.wikimedia.org wrote:
# Check the text if not in rev_len for the entry's text sizeif( !$size ) {$text = $dbw->selectField( 'text', 'old_text', array('old_id' => $textId ) );$size = $text ? strlen($text) : 'NULL';}
This will give incorrect results for compressed text, external storage entries, and batch compression entries.
You need to also fetch old_flags and run the row through the Revision::getRevisionText() function to expand such rows.
- -- brion vibber (brion @ wikimedia.org)
Hmm...right. I've removed the text checking code, so now either it is in rev_len or it is NULL.
-Aaron Schulz
From: Brion Vibber brion@wikimedia.org Reply-To: Wikimedia developers wikitech-l@lists.wikimedia.org To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] [MediaWiki-CVS] SVN:[22786] trunk/phase3/maintenance/rebuildrecentchanges.inc Date: Wed, 06 Jun 2007 09:49:35 -0400
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
aaron@svn.wikimedia.org wrote:
# Check the text if not in rev_len for the entry's text sizeif( !$size ) {$text = $dbw->selectField( 'text', 'old_text', array('old_id' =>$textId ) );
$size = $text ? strlen($text) : 'NULL';}This will give incorrect results for compressed text, external storage entries, and batch compression entries.
You need to also fetch old_flags and run the row through the Revision::getRevisionText() function to expand such rows.
- -- brion vibber (brion @ wikimedia.org)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGZrtvwRnhpk1wk44RAnznAKDHql/GH+4Dmy5JIIa0P6O4YqYxkACfc5t+ 9JX6+zT/Q77ynoXUeAEjLec= =v70C -----END PGP SIGNATURE-----
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l
_________________________________________________________________ Get a preview of Live Earth, the hottest event this summer - only on MSN http://liveearth.msn.com?source=msntaglineliveearthhm
On 07/06/07, Aaron Schulz jschulz_4587@msn.com wrote:
Hmm...right. I've removed the text checking code, so now either it is in rev_len or it is NULL.
So the script will do sweet F.A. for large wikis which had a lot of pages before the introduction of revision.rev_len, then.
Rob Church
wikitech-l@lists.wikimedia.org