Who is supposed to review changes to ZhConversion.php and related files, such as https://gerrit.wikimedia.org/r/#/c/7364/ ?
If jenkins-bot marks it as "Verified", can it be merged similarly to localization updates?
Or is anybody who knows Chinese supposed to review them?
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
"Amir E. Aharoni" amir.aharoni@mail.huji.ac.il writes:
Or is anybody who knows Chinese supposed to review them?
The only person I know who might do this is Philip: https://www.mediawiki.org/wiki/User:PhiLiP
Busy in my work. Perhaps this week.
2012/5/15 Mark A. Hershberger mah@wikimedia.org
"Amir E. Aharoni" amir.aharoni@mail.huji.ac.il writes:
Or is anybody who knows Chinese supposed to review them?
The only person I know who might do this is Philip: https://www.mediawiki.org/wiki/User:PhiLiP
-- Mark A. Hershberger Bugmeister Wikimedia Foundation mah@wikimedia.org
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Le 12/05/12 17:46, Amir E. Aharoni a écrit :
Who is supposed to review changes to ZhConversion.php and related files, such as https://gerrit.wikimedia.org/r/#/c/7364/ ?
If jenkins-bot marks it as "Verified", can it be merged similarly to localization updates?
No no!! The way we use "verified" just meant that some bots have applied dumb tests against the commit and everything seems fine.
The change still requires a human review ;-)
2012/5/15 Antoine Musso hashar+wmf@free.fr:
Le 12/05/12 17:46, Amir E. Aharoni a écrit :
Who is supposed to review changes to ZhConversion.php and related files, such as https://gerrit.wikimedia.org/r/#/c/7364/ ?
If jenkins-bot marks it as "Verified", can it be merged similarly to localization updates?
No no!! The way we use "verified" just meant that some bots have applied dumb tests against the commit and everything seems fine.
The change still requires a human review ;-)
I understand that. I just noticed that in SVN such changes were probably approved with checking it word by word.
And I didn't know that Hydriz knows Chinese. It means that we have more capacity than I thought.
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
wikitech-l@lists.wikimedia.org