Hello,
James E. Blair, from the Openstack project, wrote an async console interface to Gerrit.
The reasoning is that when you write all your code in a terminal, it makes sense to use a terminal interface to review code. It also make it async so you can review while offline (ie during travel) and sync back with Gerrit whenever you are connected again.
You can get it by doing:
pip install pbr gertty
Then create a ~/.gertty.yaml based on: https://git.openstack.org/cgit/stackforge/gertty/plain/examples/openstack-ge...
It might not work on our Gerrit setup though :-D
The announcement with more details: http://lists.openstack.org/pipermail/openstack-infra/2014-September/001904.h...
That is cool but isn't gerrit going to be shutdown soonish?
On Thu, Sep 25, 2014 at 11:22 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
James E. Blair, from the Openstack project, wrote an async console interface to Gerrit.
The reasoning is that when you write all your code in a terminal, it makes sense to use a terminal interface to review code. It also make it async so you can review while offline (ie during travel) and sync back with Gerrit whenever you are connected again.
You can get it by doing:
pip install pbr gertty
Then create a ~/.gertty.yaml based on: https://git.openstack.org/cgit/stackforge/gertty/plain/examples/openstack-ge...
It might not work on our Gerrit setup though :-D
The announcement with more details: http://lists.openstack.org/pipermail/openstack-infra/2014-September/001904.h...
-- Antoine "hashar" Musso
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Thu, 2014-09-25 at 11:32 +0200, Petr Bena wrote:
That is cool but isn't gerrit going to be shutdown soonish?
At some point Phabricator will replace Gerrit for code reviewing. See https://www.mediawiki.org/wiki/Phabricator#Migration_timeline
So you still have a few days left to try out Gertty. ;)
andre
On 25 September 2014 11:22, Antoine Musso hashar+wmf@free.fr wrote:
James E. Blair, from the Openstack project, wrote an async console interface to Gerrit.
Screenshots are available on this blog post: http://princessleia.com/journal/?p=9785
On 25 September 2014 11:22, Antoine Musso hashar+wmf@free.fr wrote:
It might not work on our Gerrit setup though :-D
It does! I used the following config section:
servers: - name: wmf url: https://gerrit.wikimedia.org/r # Your gerrit username. username: valhallasw # Set password at https://review.openstack.org/#/settings/http-password # Note this is not your launchpad password. password: xxxxxxxxxxx git-root: ~/src/
Let me start with the positive, then to some criticism that might help others get started more quickly.
The project view / change list is awesome! It's really quick to do a checkout (instantly -- after all, the change is already downloaded!) and it's great to just ALT-2 (=CR+2) a change.
However, I am running into some issues. First of all, the software has a learning curve that's comparable to Gerrit itself ('press L to get into the project list, then select projects to follow using c'). It does have on-line help (press F1), which helps. Most dangerous operations (except for CR+2) have a second prompt, so it's not too easy to break something.
Secondly. getting projects set up is a pain. First of all, it doesn't work under Screen -- the selection bar doesn't show up. Secondly, it's slow. Horribly slow. You press the magic 'L' button (to get the full project list) and then you wait. And you wait. And you wait. Loading the project list takes something like half a minute, and in the meanwhile *nothing tells you that your command has been received, *so you're never quite sure if you should just press the key again or not. ESC is supposed to bring you to a previous screen, but that also takes ages. Or doesn't work at all -- I ctrl-C'ed and restarted gertty.
However, once you're through that step -- and it's a one-time step anyway, it's pretty cool!
One other thing to note: gertty forces you to use a $DIR//project/subproject/etc git structure. Not a disaster, but it would have been great if I could just have used my existing repositories.
Merlijn
wikitech-l@lists.wikimedia.org