Back in June the Selenium Framework had a local configuration file called LocalSeleniumSettings.php. This was eliminated by Tim Starling in a 6/24 commit with the comment that it was an insecure concept. In that commit, new globals were added that controlled test runs.
Last Friday, mah ripped out the globals and put the configuration information into the execute method of RunSeleniumTests.php with the comment "@todo Add an alternative where settings are read from an INI file." So, it seems we have dueling developers with contrary ideas about what is the best way to configure selenium framework tests. Should configuration data be exposed as globals or hidden in a local configuration file?
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult. I am working on code not yet submitted as a patch that now requires reworking because how to reference configuration data has changed. We need a decision that decides which of the two approaches to use.
Dan Nessett wrote:
Back in June the Selenium Framework had a local configuration file called LocalSeleniumSettings.php. This was eliminated by Tim Starling in a 6/24 commit with the comment that it was an insecure concept. In that commit, new globals were added that controlled test runs.
Last Friday, mah ripped out the globals and put the configuration information into the execute method of RunSeleniumTests.php with the comment "@todo Add an alternative where settings are read from an INI file." So, it seems we have dueling developers with contrary ideas about what is the best way to configure selenium framework tests. Should configuration data be exposed as globals or hidden in a local configuration file?
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult. I am working on code not yet submitted as a patch that now requires reworking because how to reference configuration data has changed. We need a decision that decides which of the two approaches to use.
A more neutral solution could be to provide a hook to set them.
Dan Nessett dnessett@yahoo.com writes:
Last Friday, mah ripped out the globals and put the configuration information into the execute method of RunSeleniumTests.php with the comment "@todo Add an alternative where settings are read from an INI file." So, it seems we have dueling developers with contrary ideas about what is the best way to configure selenium framework tests.
I'm opposed to increasing global variables and I think I understand Tim's concern about configuring via a PHP file.
I plan to start work on reading the configuration from an INI file (*not* a PHP file).
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult.
I agree.
The idea I was pursuing is to encapsulate configuration in a Selenium object that (right now) RunSeleniumTests.php will set up.
Platonides suggestion of a hook to provide configuration is also doable.
Mark.
Embrace Ignorance. Just don't get too attached.
Hi,
Great, that there is some further discussion and progress in Selenium testing going on.
However, up to now I have been following the manual at [1] which Markus Glaser has updated recently but which now is out-of-date. I have figured out some of your changes and almost got the framework working. But still, SimpleSeleniumTestSuite/SimpleSeleniumTestCase do not work due to a "call_user_func_array()" error. Apparently, some methods cannot be found.
I was wondering whether it would be possible to update the manual at [1] if there are any changes to the framework concerning its usage.
Regards,
Benedikt
-- Karlsruhe Institute of Technology (KIT) Institute of Applied Informatics and Formal Description Methods (AIFB)
Benedikt Kämpgen Research Associate
Kaiserstraße 12 Building 11.40 76131 Karlsruhe, Germany
Phone: +49 721 608-7946 Fax: +49 721 608-6580 Email: benedikt.kaempgen@kit.edu Web: http://www.kit.edu/
KIT - University of the State of Baden-Wuerttemberg and National Research Center of the Helmholtz Association
-----Original Message----- From: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Mark A. Hershberger Sent: Tuesday, September 07, 2010 5:15 AM To: Wikimedia developers Subject: Re: [Wikitech-l] Selenium Framework - test run configuration data
Dan Nessett dnessett@yahoo.com writes:
Last Friday, mah ripped out the globals and put the configuration information into the execute method of RunSeleniumTests.php with the comment "@todo Add an alternative where settings are read from an INI file." So, it seems we have dueling developers with contrary ideas about what is the best way to configure selenium framework tests.
I'm opposed to increasing global variables and I think I understand Tim's concern about configuring via a PHP file.
I plan to start work on reading the configuration from an INI file (*not* a PHP file).
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult.
I agree.
The idea I was pursuing is to encapsulate configuration in a Selenium object that (right now) RunSeleniumTests.php will set up.
Platonides suggestion of a hook to provide configuration is also doable.
Mark.
Embrace Ignorance. Just don't get too attached.
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Mon, 06 Sep 2010 23:15:06 -0400, Mark A. Hershberger wrote:
Dan Nessett dnessett@yahoo.com writes:
Last Friday, mah ripped out the globals and put the configuration information into the execute method of RunSeleniumTests.php with the comment "@todo Add an alternative where settings are read from an INI file." So, it seems we have dueling developers with contrary ideas about what is the best way to configure selenium framework tests.
I'm opposed to increasing global variables and I think I understand Tim's concern about configuring via a PHP file.
I plan to start work on reading the configuration from an INI file (*not* a PHP file).
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult.
I agree.
The idea I was pursuing is to encapsulate configuration in a Selenium object that (right now) RunSeleniumTests.php will set up.
Platonides suggestion of a hook to provide configuration is also doable.
Mark.
I am pretty much agreeable to any solution that remains stable. One thing that may not be obvious is there may be configuration data over and above that specified on the RunSeleniumTests command line.
For example, it is inconvenient to have to start up the selenium server before running RunSeleniumTests. (In the past I have frequently executed RunSeleniumTests only to get an error because I forgot to start the server). I supplied a patch to Markus recently that adds two options to the command line, one to start the server and the other to stop it (the patch supplies functionality only for *nix systems, which is probably why Markus has not committed it - there needs to be similar support for Windows). This functionality requires a directory path to the selenium server jar file. This is not something that a tester would normally supply on a command line. It is a system, not a test run parameter.
So, I hope the INI file processing you are working on will allow the specification of such data.
Dan Nessett dnessett@yahoo.com writes:
Either approach works. But, by going back and forth, it makes development of functionality for the Framework difficult.
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Mark.
I would be happy to coordinate with you. Up to this point I have been working with Markus Glaser and that has gone pretty well. But, I would welcome more discussion on issues, architecture and implementation strategy for the Framework as well as making sure anything I do fits in with what others are doing.
Regards,
Dan
--- On Tue, 9/7/10, Mark A. Hershberger mah@everybody.org wrote:
From: Mark A. Hershberger mah@everybody.org Subject: Re: Selenium Framework - test run configuration data To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Cc: "Dan Nessett" dnessett@yahoo.com Date: Tuesday, September 7, 2010, 8:04 AM Dan Nessett dnessett@yahoo.com writes:
Either approach works. But, by going back and forth,
it makes development
of functionality for the Framework difficult.
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Mark.
Embrace Ignorance. Just don't get too attached.
Hi all,
I suggest we have one static class variable Selenium::$settings which is set up as an array. This array would be filled in some init function from whatever sources we decide on. Then, internally, the configuration mechanisms would not change anymore, and we could use the init method to fill the settings from globals (as is) or ini files (as Mark propses). Those who use the framework, however, would not have to rewrite their code.
Regards, Markus
Markus Glaser Social Web Technologien Leiter Softwareentwicklung Hallo Welt! - Medienwerkstatt GmbH __________________________________
Untere Bachgasse 15 93047 Regensburg
Tel. +49 (0) 941 - 56 95 94 92 Fax. +49 (0) 941 - 50 27 58 13
www.hallowelt.biz glaser@hallowelt.biz
Sitz: Regensburg Handelsregister: HRB 10467 E.USt.Nr.: DE 253050833 Geschäftsführer: Anja Ebersbach, Markus Glaser, Dr. Richard Heigl, Radovan Kubani
-----Ursprüngliche Nachricht----- Von: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] Im Auftrag von dan nessett Gesendet: Dienstag, 7. September 2010 17:20 An: Wikimedia developers; Mark A. Hershberger Betreff: Re: [Wikitech-l] Selenium Framework - test run configuration data
I would be happy to coordinate with you. Up to this point I have been working with Markus Glaser and that has gone pretty well. But, I would welcome more discussion on issues, architecture and implementation strategy for the Framework as well as making sure anything I do fits in with what others are doing.
Regards,
Dan
--- On Tue, 9/7/10, Mark A. Hershberger mah@everybody.org wrote:
From: Mark A. Hershberger mah@everybody.org Subject: Re: Selenium Framework - test run configuration data To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Cc: "Dan Nessett" dnessett@yahoo.com Date: Tuesday, September 7, 2010, 8:04 AM Dan Nessett dnessett@yahoo.com writes:
Either approach works. But, by going back and forth,
it makes development
of functionality for the Framework difficult.
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Mark.
Embrace Ignorance. Just don't get too attached.
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Tue, 07 Sep 2010 17:39:19 +0200, Markus Glaser wrote:
Hi all,
I suggest we have one static class variable Selenium::$settings which is set up as an array. This array would be filled in some init function from whatever sources we decide on. Then, internally, the configuration mechanisms would not change anymore, and we could use the init method to fill the settings from globals (as is) or ini files (as Mark propses). Those who use the framework, however, would not have to rewrite their code.
Regards, Markus
Markus Glaser Social Web Technologien Leiter Softwareentwicklung Hallo Welt! - Medienwerkstatt GmbH __________________________________
Untere Bachgasse 15 93047 Regensburg
Tel. +49 (0) 941 - 56 95 94 92 Fax. +49 (0) 941 - 50 27 58 13
www.hallowelt.biz glaser@hallowelt.biz
Sitz: Regensburg Handelsregister: HRB 10467 E.USt.Nr.: DE 253050833 Geschäftsführer: Anja Ebersbach, Markus Glaser, Dr. Richard Heigl, Radovan Kubani
-----Ursprüngliche Nachricht----- Von: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] Im Auftrag von dan nessett Gesendet: Dienstag, 7. September 2010 17:20 An: Wikimedia developers; Mark A. Hershberger Betreff: Re: [Wikitech-l] Selenium Framework - test run configuration data
I would be happy to coordinate with you. Up to this point I have been working with Markus Glaser and that has gone pretty well. But, I would welcome more discussion on issues, architecture and implementation strategy for the Framework as well as making sure anything I do fits in with what others are doing.
Regards,
Dan
--- On Tue, 9/7/10, Mark A. Hershberger mah@everybody.org wrote:
From: Mark A. Hershberger mah@everybody.org Subject: Re: Selenium Framework - test run configuration data To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Cc: "Dan Nessett" dnessett@yahoo.com Date: Tuesday, September 7, 2010, 8:04 AM Dan Nessett dnessett@yahoo.com writes:
Either approach works. But, by going back and forth,
it makes development
of functionality for the Framework difficult.
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Mark.
Embrace Ignorance. Just don't get too attached.
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
This seems like a reasonable strategy to me.
Dan
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Please coordinate through wikitech-l and the SeleniumFramework page on mediawiki.org [1]. It is good to broadcast information through other sources as well, but normal communication methods are best. If changes are being made to the framework, the documentation should also be updated.
-- Ryan
I made a few changes to the test runner and how we configure it. Also changed the mediawiki page to reflect this: http://www.mediawiki.org/wiki/SeleniumFramework#Configure_the_framework
-p
On 09/07/2010 09:52 AM, Ryan Lane wrote:
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Please coordinate through wikitech-l and the SeleniumFramework page on mediawiki.org [1]. It is good to broadcast information through other sources as well, but normal communication methods are best. If changes are being made to the framework, the documentation should also be updated.
-- Ryan
[1] http://www.mediawiki.org/wiki/SeleniumFramework
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi Priyanka,
Thanks for the update of the framework documentation. I will try to have a look at it soon.
Cheers!
Benedikt
-- Karlsruhe Institute of Technology (KIT) Institute of Applied Informatics and Formal Description Methods (AIFB)
Benedikt Kämpgen Research Associate
Kaiserstraße 12 Building 11.40 76131 Karlsruhe, Germany
Phone: +49 721 608-7946 Fax: +49 721 608-6580 Email: benedikt.kaempgen@kit.edu Web: http://www.kit.edu/
KIT University of the State of Baden-Wuerttemberg and National Research Center of the Helmholtz Association
-----Original Message----- From: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Priyanka Dhanda Sent: Wednesday, September 22, 2010 2:29 AM To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] Selenium Framework - test run configuration data
I made a few changes to the test runner and how we configure it. Also changed the mediawiki page to reflect this: http://www.mediawiki.org/wiki/SeleniumFramework#Configure_the_framework
-p
On 09/07/2010 09:52 AM, Ryan Lane wrote:
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Please coordinate through wikitech-l and the SeleniumFramework page on mediawiki.org [1]. It is good to broadcast information through other sources as well, but normal communication methods are best. If changes are being made to the framework, the documentation should also be updated.
-- Ryan
[1] http://www.mediawiki.org/wiki/SeleniumFramework
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi,
The selenium framework configuration using a config file [1] is much clearer now. Thanks.
Regards,
Benedikt
[1] http://www.mediawiki.org/wiki/SeleniumFramework#Configure_Selenium_using_a_c onfiguration_file
-- Karlsruher Institut für Technologie (KIT) Institut für Angewandte Informatik und Formale Beschreibungsverfahren (AIFB)
Benedikt Kämpgen Wissenschaftlicher Mitarbeiter
Kaiserstraße 12 Gebäude 11.40 76131 Karlsruhe
Telefon: +49 721 608-7946 Fax: +49 721 608-6580 E-Mail: benedikt.kaempgen@kit.edu Web: http://www.kit.edu/ KIT Universität des Landes Baden-Württemberg und nationales Forschungszentrum in der Helmholtz-Gemeinschaft
-----Original Message----- From: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Benedikt Kaempgen Sent: Thursday, October 07, 2010 11:28 PM To: pdhanda@wikimedia.org; Wikimedia developers Subject: Re: [Wikitech-l] Selenium Framework - test run configuration data
Hi Priyanka,
Thanks for the update of the framework documentation. I will try to have a look at it soon.
Cheers!
Benedikt
-- Karlsruhe Institute of Technology (KIT) Institute of Applied Informatics and Formal Description Methods (AIFB)
Benedikt Kämpgen Research Associate
Kaiserstraße 12 Building 11.40 76131 Karlsruhe, Germany
Phone: +49 721 608-7946 Fax: +49 721 608-6580 Email: benedikt.kaempgen@kit.edu Web: http://www.kit.edu/
KIT University of the State of Baden-Wuerttemberg and National Research Center of the Helmholtz Association
-----Original Message----- From: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Priyanka Dhanda Sent: Wednesday, September 22, 2010 2:29 AM To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] Selenium Framework - test run configuration data
I made a few changes to the test runner and how we configure it. Also changed the mediawiki page to reflect this: http://www.mediawiki.org/wiki/SeleniumFramework#Configure_the_framework
-p
On 09/07/2010 09:52 AM, Ryan Lane wrote:
I should also point out that what I was planning to do was not hidden. I wrote about these changes in my weekly report the Monday before I committed them (http://bit.ly/cqAcqz) and pointed to the weekly report from my Ohloh, Twitter, Identi.ca and Facebook accounts.
Granted, this is not the same as posting to the mailing list, and for that I apologize.
Looking back in the archives on gmane, it looks like you are very interested in MW testing. Since this is a large part of my focus currently as well, perhaps we should coordinate our work?
Please coordinate through wikitech-l and the SeleniumFramework page on mediawiki.org [1]. It is good to broadcast information through other sources as well, but normal communication methods are best. If changes are being made to the framework, the documentation should also be updated.
-- Ryan
[1] http://www.mediawiki.org/wiki/SeleniumFramework
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Priyanka Dhanda Code Maintenance Engineer Wikimedia Foundation http://wikimediafoundation.org San Francisco, CA
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org