On Fri, Aug 23, 2013 at 6:39 PM, Greg Grossmeier greg@wikimedia.org wrote:
== Thursday ==
- CodeEditor support will be enabled for all JS and CSS on all wikis
Without fixing the bug which makes it use spaces instead of tabs? Seriously? https://bugzilla.wikimedia.org/show_bug.cgi?id=39616
Helder
Helder . wrote:
On Fri, Aug 23, 2013 at 6:39 PM, Greg Grossmeier greg@wikimedia.org wrote:
== Thursday ==
- CodeEditor support will be enabled for all JS and CSS on all wikis
Without fixing the bug which makes it use spaces instead of tabs? Seriously? https://bugzilla.wikimedia.org/show_bug.cgi?id=39616
This bug is now resolved/fixed. :-) Thanks to Alex M. and Ori L. for working on this.
I created https://meta.wikimedia.org/wiki/CodeEditor. Any help getting this page translated and advertised (to the ambassadors mailing list, etc.) would be great. It should possibly be merged with https://www.mediawiki.org/wiki/Extension:CodeEditor in the future, but for now it seemed more right to keep the two separate.
There was a fleeting thought of having the WikimediaMessages extension hook into the CodeEditor extension to add a header message above the edit window if CodeEditor is activated. This header message could be used to explain what CodeEditor is and link to more information about it, but... it's probably more trouble than it's worth to implement this.
And I came across https://bugzilla.wikimedia.org/53300 today (CodeEditor and UniversalLanguageSelector don't seem to play very nicely together). It'd be cool to get that bug resolved before Thursday.
MZMcBride
On Tue, Aug 27, 2013 at 10:01 PM, MZMcBride z@mzmcbride.com wrote:
Helder . wrote:
On Fri, Aug 23, 2013 at 6:39 PM, Greg Grossmeier greg@wikimedia.org wrote:
== Thursday ==
- CodeEditor support will be enabled for all JS and CSS on all wikis
Without fixing the bug which makes it use spaces instead of tabs? Seriously? https://bugzilla.wikimedia.org/show_bug.cgi?id=39616
This bug is now resolved/fixed. :-) Thanks to Alex M. and Ori L. for working on this.
That reminds me. The patch adds a JS hook so individual users can select spaces vs tabs for their newly-added lines. Is this going to cause complaints that pages wind up with a mixture of lines indented with spaces and lines indented with tabs? Also, how is indenting with tabs going to interact with people who use the plain-text editor rather than CodeEditor, since it's somewhat difficult to use tabs there because the tab key moves to the next form field?
On Wed, Aug 28, 2013 at 6:29 AM, Brad Jorsch (Anomie) <bjorsch@wikimedia.org
wrote:
That reminds me. The patch adds a JS hook so individual users can select spaces vs tabs for their newly-added lines. Is this going to cause complaints that pages wind up with a mixture of lines indented with spaces and lines indented with tabs? Also, how is indenting with tabs going to interact with people who use the plain-text editor rather than CodeEditor, since it's somewhat difficult to use tabs there because the tab key moves to the next form field?
IMO we should phase out use of the literal tab character, which is very..... teletype-centric. I would recommend normalizing tabs on input into four-spaces.
But keeping existing behavior when cut-n-pasting text with tabs isn't awful for now, I suppose.
This doesn't add *new* tabs when typing code does it?
-- brion
wikitech-l@lists.wikimedia.org