brion@svn.wikimedia.org schreef:
- Asks server for mime type, but doesn't get it back yet
That's due to a typo:
- function findFile( $title, $time = false ) {
$info = $this->queryImage( array('titles' => 'Image:' . $title->getText(),'prop' => 'imageinfo','iiprop' => 'timestamp|user|comment|url|size|sha1|metadata|mimetype' ) );
There it is. You should use iiprop=mime, not iiprop=mimetype.
The rest of this stuff looks good. You seem to have fixed the canonical namespace thing. To what degree did you test/profile/benchmark this?
Roan Kattouw (Catrope)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Roan Kattouw wrote:
brion@svn.wikimedia.org schreef:
- Asks server for mime type, but doesn't get it back yet
That's due to a typo:
- function findFile( $title, $time = false ) {
$info = $this->queryImage( array('titles' => 'Image:' . $title->getText(),'prop' => 'imageinfo','iiprop' => 'timestamp|user|comment|url|size|sha1|metadata|mimetype' ) );There it is. You should use iiprop=mime, not iiprop=mimetype.
Ah, but I didn't get a mime back with my query with "mime" until I fixed the API's own typo -- it looked for "mimetype" but that didn't get past the input validation -- in r35185... :)
The rest of this stuff looks good. You seem to have fixed the canonical namespace thing. To what degree did you test/profile/benchmark this?
Pretty much not profiled or benchmarked at all. :)
Just poking at it a bit on my test comp. I wouldn't recommend it for general use at the moment.
- -- brion
wikitech-l@lists.wikimedia.org