tstarling@svn.wikimedia.org schrieb:
Revision: 25335 Author: tstarling Date: 2007-08-31 02:51:23 +0000 (Fri, 31 Aug 2007)
Log Message:
Elsewhere:
- Changed MediaTransformOutput::toHtml() parameters, now accepts a single associative array with well-defined elements. Allows OggHandler to distinguish between file download links and image description links.
- Made image links consistently have an anchor tag with class=image, instead of a mixture of image and internalParse.
- Made most images have a border=0 attribute, instead of just images on the image description page. Does not appear to adversely affect display at all, it was just convenient.
- Use the image name as the title attribute for the <a> tag, when an a caption was not given by the user
- Block centering by the auto margins method in ImageGallery
- Fixed complete breakage of the thumbnail on upload conflict feature
Modified: trunk/phase3/includes/MediaTransformOutput.php
@@ -60,6 +73,19 @@ return $contents; } }
- function getDescLinkAttribs( $alt = false ) {
$query = $this->page ? ( 'page=' . urlencode( $this->page ) ) : '';
$title = $this->file->getTitle();
if ( strval( $alt ) === '' ) {
$alt = $title->getText();
}
rebuildAll.php is broken now:
F:\xampp\htdocs\wikitest\maintenance>php rebuildall.php
[...]
** Rebuilding links tables -- this can take a long time. It should be safe to abort via ctrl+C if you get bored. Refreshing links table. Starting from page_id 1 of 208.
Fatal error: Call to a member function getTitle() on a non-object in F:\xampp\ht docs\wikitest\includes\MediaTransformOutput.php on line 79
Raymond.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Raimond Spekking wrote:
rebuildAll.php is broken now:
F:\xampp\htdocs\wikitest\maintenance>php rebuildall.php
[...]
** Rebuilding links tables -- this can take a long time. It should be safe to abort via ctrl+C if you get bored. Refreshing links table. Starting from page_id 1 of 208.
Fatal error: Call to a member function getTitle() on a non-object in F:\xampp\ht docs\wikitest\includes\MediaTransformOutput.php on line 79
No problem here. Can you narrow it down to a specific page which croaks?
- -- brion vibber (brion @ wikimedia.org)
Brion Vibber schrieb:
Raimond Spekking wrote:
Fatal error: Call to a member function getTitle() on a non-object in F:\xampp\ht docs\wikitest\includes\MediaTransformOutput.php on line 79
No problem here. Can you narrow it down to a specific page which croaks?
Sorry, false alarm :-(
Not a specific page croaks but the PDFHandler extension I am testing. I haven't thought about that because it works well before the latest changes to MediaTransformOutput.php are made.
I will look into PDFHandler now. Thanks for your time.
Raymond.
wikitech-l@lists.wikimedia.org