The link placeholders are causing lots of problems in 1.4: links that do not appear in the body text end up with the placeholder comments but are never replaced with the actual links.
For example, the user name in the subtitle for Special:Contributions. This may be behind http://bugzilla.wikipedia.org/206 also.
This is kind of a problem. Do we need a way to turn the placeholdering on and off, or should we have distinct makeLink* functions for making placeholder links?
-- brion vibber (brion @ pobox.com)
On Tue, Aug 24, 2004 at 11:10:34AM -0700, Brion Vibber wrote:
The link placeholders are causing lots of problems in 1.4: links that do not appear in the body text end up with the placeholder comments but are never replaced with the actual links.
For example, the user name in the subtitle for Special:Contributions. This may be behind http://bugzilla.wikipedia.org/206 also.
This is kind of a problem. Do we need a way to turn the placeholdering on and off, or should we have distinct makeLink* functions for making placeholder links?
My understanding is that postParseLinkColour is used to switch between the two modes.
Regards,
JeLuF
Brion Vibber wrote:
The link placeholders are causing lots of problems in 1.4: links that do not appear in the body text end up with the placeholder comments but are never replaced with the actual links.
For example, the user name in the subtitle for Special:Contributions. This may be behind http://bugzilla.wikipedia.org/206 also.
This is kind of a problem. Do we need a way to turn the placeholdering on and off, or should we have distinct makeLink* functions for making placeholder links?
The sequence of events should be:
* Text is added to the buffer, including placeholder comments * OutputPage::output is called - Placeholders are processed - Placeholders are turned off using $sk->postParseLinkColour(false) - Control is passed to $sk->outputPage() - Navigation links are constructed by calling Skin::makeLink() and outputting them directly, no more post-processing is done
Anything else is a bug, most likely introduced after I did my initial testing of this feature.
-- Tim Starling
Tim Starling wrote:
The sequence of events should be:
- Text is added to the buffer, including placeholder comments
- OutputPage::output is called
- Placeholders are processed
- Placeholders are turned off using $sk->postParseLinkColour(false)
- Control is passed to $sk->outputPage()
- Navigation links are constructed by calling Skin::makeLink() and outputting them directly, no more post-processing is done
Various special pages construct additional bits such as the subtitle in their own function, which happens before passing to $sk->outputPage().
-- brion vibber (brion @ pobox.com)
wikitech-l@lists.wikimedia.org