Hi Niklas,
On Thu, Mar 14, 2013 at 10:54:05AM +0200, Niklas Laxström wrote:
On 14 March 2013 01:07, Christian Aistleitner christian@quelltextlich.at wrote:
Queries are just a grep away, and setting them can be done through git as well, until we integrate that into gerrit.
Except that you need to have the repository cloned locally first.
That's only valid until we integrate git notes somewhere.
And given that other solutions cannot be used /at all/ until we integrate them somewhere, I take your comment as discussion of "how big the 'git notes' benefit is today" instead of whether git notes would be useful :-)
In addition to that, consider that git comes with git notes support for free. No need to code REST apis for scripts to give them access to the information.
No need to fiddle in logging who added/removed which tags, and when this happened. It all comes automatically with git. And we can use our plain git tools like gitk to browse through history of the tags.
Finally, we already export part of the gerrit meta-data through git notes. For example the review meta-data is avalable via refs/notes/review.
So after doing
git fetch origin refs/notes/review:refs/notes/review
in a core checkout,
git log --show-notes=review
shows you who gave what review for which commits, and links to the commits discussion in gerrit.
So why not building further on what we are using already instead of reinventing the wheel once again?
And often you need to query multiple repositories.
Yes, without proper integration in some tool, multi-project queries need something like a three-line script when done straight from git.
But at least we can use it even without integration in some other tool. Other solutions cannot be used at all without integration :-)
Best regards, Christian