Gregory Maxwell wrote:
On Wed, Feb 10, 2010 at 12:51 AM, tstarling@svn.wikimedia.org wrote:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/62223
Revision: 62223 Author: tstarling Date: 2010-02-10 05:51:56 +0000 (Wed, 10 Feb 2010)
Log Message:
- In preparation for deployment, revert the bulk of Michael's unreviewed work. Time for review has run out. The code has many obvious problems with it. Comparing against r38714 will give you an idea of which changes I am accepting. Fixes bug 22388.
- Removed magic word hook, doesn't do anything useful.
- OggPlayer.js still needs some work.
Looks like this change removed both the Oggthumb support as well as the code that handles the cases where ffmpeg fails.
Ffmpeg will fail to generate a thumb if there is no keyframe in the file after the point in time that you requested a thumb. This was causing a failure to generate thumbs for many files because they are short and only have a single keyframe at the beginning.
That sounds like it needs a one-line fix in OggHandler::normaliseParams(), not 50 lines of code and a new decoder. Do you have a test file or a bug report or something?
-- Tim Starling