Hey everyone,
and thanks for your help so far. We continued setting up our working environment and have a couple more questions especially regarding the code review process:
Obviously we need some place to store code during development and exchange code without third party reviewing of every commit. Is giving us push rights in our gerrit project for developing on a develop branch and asking for code reviews via the mailing list before merging to the master branch the correct process? Or should we develop and exchange code for example in a github repository and only push patches to gerrit and then ask someone for code review?
Background where we are coming from:
Sebastian and I are now project owners for https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MOOC this can be seen from: https://gerrit.wikimedia.org/r/#/admin/groups/1184,members In the beginning we could not exchange code by pushing changes to the develop branch but could only push to new branches. we could fix this by adding push rights to the extension-MOOC group Now we are confused! On https://www.mediawiki.org/wiki/Gerrit/%2B2 we read that we should not +2 our own code - even if we are project owners. in IRC we had the following conversation that suggested otherwise:
[10:22] <legoktm> renepick: it's designed for merge review...so you upload the patch using git review (or the magical git push origin HEAD:refs/for/master) which uploads it to gerrit for review, which you then +2 [10:30] <renepick> @legoktm: on the docu it says that one should not self +2 ones own code [10:30] <legoktm> that's an ideal, but it really depends on whether you have someone else to review your code for you
Obviously today we just played around with sample code and rights management in gerrit. So we do not have something for review even though there where some commits. But it is important for us and our future development process to understand the customs and processes that are going on here.
best regards Rene
On Fri, Apr 15, 2016 at 12:34 AM, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 04/13/2016 09:21 AM, Marko Obrovac wrote:
Right. Not everything needs a Vagrant role. However, having one definitely increases the chance of people using your extension :) As Baha suggested, you can file a new task in Phabricator and tag it with the MediaWiki-Vagrant project.
Yes. A good example of a very simple role is role::doublewiki (but please put a better description than that). If your extension needs update.php, grep for needs_update. role::cite is almost as simple, but shows how config settings work.
And you can feel free to ask on Phabricator or here for help.
Matt
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l