On Tue, Aug 16, 2011 at 3:37 AM, bawolff bawolff+wn@gmail.com wrote:
Message: 4 Date: Mon, 15 Aug 2011 19:49:40 -0400 From: mhershberger@wikimedia.org (Mark A. Hershberger) Subject: [Wikitech-l] Mobile bug Triage ? non-WMF devs wanted! To: Wikitech List wikitech-l@lists.wikimedia.org Message-ID: 87k4aeme0b.fsf@everybody.org Content-Type: text/plain; charset=utf-8
What: ?Mobile? bug triage When: Wednesday, August 17, 17:00UTC Time zone conversion: http://hexm.de/5r Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/ if you don't have an IRC client
This Wednesday, I'll be conducting a bug triage of bugs related to mobile devices and the new MobileFrontend Extension. In order to get as much non-WMF interest as possible, I'm announcing the triage two days early.
If you have a wiki that you would like to add mobile support to, then this is the triage for you! You'll have a chance to talk to developers about the issues and, if you can help with PHP development, you'll be able to see which bugs are most important to you to be fixed and even get some hints to begin diving into the code yourself.
If we're trying to attract non-wmf devs, parts of the extension seems very wmf specific (or do you mean we're trying to attract volunteer devs who only care about Wikipedia?).
For example, at one part there is a check hardcoding things specific to the wmf server setup: stripos( $_SERVER['HTTP_VIA'], '.wikimedia.org:3128' ) !== false )
This is needed to work around a caching issue. I guess we should wrap that around a config variable that is specific to our environment. Or, provide the functionality in another way.
There's another line doing stuff like: $featuredArticle = $this->mainPage->getElementById( 'mp-tfa' ); $newsItems = $this->mainPage->getElementById( 'mp-itn' );
Which I assume is a refrence to class names used on the english wikipedia's main page.
Yes, it is a reference to the main page class names. We could also take the config variable approach.
I personally feel (without actually looking at the issues involved, so take this with salt) that its bad to hardcode such things even if its only going to be used by wmf, since they can change.
Duly noted. I appreciate your thoughts on the matter.
However if we're
aiming for third party re-use, then hardcoding such things is definitely a bad idea.
Okay, we'll see what we can do to fix that issue. Or, at least mitigate any risk for third parties.
-bawolff
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l