On Thu, Oct 4, 2018 at 11:15 AM, Gergo Tisza gtisza@wikimedia.org wrote:
- Avatars are really nice and make the whole experience more human. (They
are not enabled on the Wikimedia Gerrit yet, right?)
Yes, that is/was a bit more complicated than it may seem. For security reasons we have a separate domain for user uploads.
As you might have noticed on Phabricator we use phab.wmfusercontent.org for uploaded files. In the same way we needed to first create gerrit.wmfusercontent.org to make this possible, followed by Varnish config for it, then Apache and so on.
As Paladox pointed out a bunch of things have already been merged but at least 2 are left open. Having reviewed/merged most of the previous ones i will look into pushing this forward again to finalize it. Then we will have avatars on Gerrit.
https://phabricator.wikimedia.org/T191183#4278525
https://gerrit.wikimedia.org/r/#/q/project:operations/puppet+branch:producti...