Just to add to the technical stuff:- * We made a local repo to fork the original swiftmailer repo at https://github.com/wikimedia/mediawiki-core-vendor-swiftmailer/tree/5.2.0-pa..., and our https://gerrit.wikimedia.org/r/#/c/137538/ makes composer take up the files from our repo and not the upstream one, which is for the development end. * Our VERP project is going on at https://gerrit.wikimedia.org/r/#/c/138655/
Thanks, Tony Thomas http://tttwrites.in FOSS@Amrita http://foss.amrita.ac.in
*"where there is a wifi, there is a way"*
On Wed, Jun 11, 2014 at 1:10 PM, Adrian Lang adrian.lang@wikimedia.de wrote:
Hi,
from my point of view this discussion mixes two or three different questions:
- Do we want core to regularly use external libraries (which are
installed via one git submodule or composer)?
- Should Swiftmailer be used in core?
- (How) Do we want to handle this for plain git cloning to be usable?
I think the first question is sort of answered, although maybe not everybody committed on that.
The second question is something different entirely. From my point of view it doesn't make any sense to discuss this here, because (considering how we IMHO answered the first question) we will have a required dependency eventually, even if that is not going to be Swiftmailer.
The third question is what Tim actually asked, and it's an interesting, technical question we should focus on. I like Tim's suggestion of having an optional git submodule. The installer could then show an error if vendor/ is missing proposing to either run "composer install" or "git submodule update --init". Do we also have to consider composer.lock?
Regards, Adrian
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l