On 02/14/2013 07:29 PM, Krinkle wrote:
Due to the way Git and Gerrit interact, a revert (unlike a merge) is a two-step process. It considers it to be a separate commit (which it is, of course). So clicking Revert only drafts a commit, it still needs to be merged. This is generally done straight away if the revert reason comes from someone with merge rights.
I'm not sure this should be an exception. In general (potentially excluding urgent hotfixes if one is confident the fix is correct), the decision to revert itself should be reviewed.
Matt Flaschen