On 2014-05-24, 10:49 AM, Bartosz Dziewoński wrote:
On Wed, 21 May 2014 09:48:21 +0200, Daniel Friesen daniel@nadir-seen-fire.com wrote:
And for the bit on re-caching that is simple. Assets for core skins like Vector and old skins that are implemented using the autoloader are currently at: {mediawiki}/skins/vector/* If you change the directory structure so we load $IP/skins/Vector/Vector.php (instead of $IP/skin/vector/vector.php) then the path to assets becomes: {mediawiki}/skins/Vector/* Even though not a single one of the assets have changed the URL has, so, re-cache. ResourceLoader moves most CSS, JS, and some images to load.php but there are still resources that are referred to with an actual URL, like Vector's .htc file, all css images in IE without data: URI support, css images that aren't marked with @embed (because they're too big, use multi-backgrounds, etc...), anything in an <img> using $skin->getSkinStylePath(...), and any stylesheet still loaded with addStyle (IE stylesheets, etc...).
I'm sorry, but this is very silly reasoning. Cache is not forever anyway, and ResourceLoader includes cache-busting timestamps in URL queries for each resource that goes through it (including the ones that are not embedded in CSS, and the fallbacks for data: URIs). Changing the URL is not a problem at all as long as we're not doing it every other day.
It's not my most important point, but just a few notes since you replied.
* Just a few strict fact corrections: o The .htc doesn't get cache busted. o addStyle, etc... are cache busted by $wgStyleVersion not RL. o CSS contents in RL get cache busters, but the load.php calls themselves for skin resources don't. * The "cache" problem isn't just an issue of things unnecessarily being purged. Remember WMF's 30 day cache issues. Unless the wmfX number is already something that would be changed with two copies being simultaneously deployed the vector -> Vector path change triggers the issue of old cached pages pointing to
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]