On Thu, Nov 3, 2011 at 2:08 PM, DJ Bauch dj.bauch@gmail.com wrote:
I don't have a manifestation of this bug, but somebody working on the installer should look at WebInstaller.php, lines 640 and 641, which both assign to the $html variable. They can't both be right. In effect, 640 does nothing. In older revisions, the line $html = $this->parse( $text, true); was $html = $this->parse( $html, true); The $html value having been set on the previous line with $html = htmlspecialchars( $text ); just as it still is.
Added a note on code review: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/100126#c25435
It looks like the cleanup changed this from an accidental leftover line and then parsing, to escaping and then parsing, which doesn't look right to me. Should probably remove that previous line with the htmlspecialchars() and pass $text into parse() as before?
-- brion