I agree with pretty much all of this. In my mind, editcontentmodel is a temporary hack that should go away completely once the bugs that led to its creation are fixed.
Jackmcbarn
On Fri, Jan 23, 2015 at 1:00 AM, Legoktm legoktm.wikipedia@gmail.com wrote:
Hi,
On 01/09/2015 04:25 PM, Erik Bernhardson wrote:
However, changing the content model of an existing page is a disruptive change. We added the right `editcontentmodel` without which attempts to change content model through the API or EditPage.php fail. Currently no group (user or bot) has this right. So we think it's OK and safe to
enable
$wgContentHandlerUseDB on WMF wikis. https://gerrit.wikimedia.org/r/#/c/170129/ is the patch.
I think this is fine to turn on as well.
There are issues with granting the editcontentmodel right, see T85847.
I disagree that we need a "editcontentmodel" user right. I think all users should be allowed to change the content model of a page (provided they have the right to edit it, etc.). Changing the content model of a page is currently disruptive because the only way to do it (and undo it) is via the API[1], and normal tools like undo don't work[2]. For now I'd suggest we grant it to syops and then later on grant it to '*' by default.
Daniel Kinzler proposed that we should not grant the editcontentmodel
right
because any change to content model is a special case that requires smart handling via dedicated PHP code. Which is what Flow is doing for both the Co-op bot and the future Special:Flowify.
That might make sense for changing the content model of an existing page, but I don't think it applies for when we want to create a new page with a content model different from the default. For example, in the MassMessage extension we let people create pages with the "MassMessageListContent" type wherever they want. It's not set as a default anywhere meaning that you currently need the "editcontentmodel" right to just create a list. :/
[1] https://phabricator.wikimedia.org/T72592 [2] https://phabricator.wikimedia.org/T73163
-- Legoktm
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l