+1 to Lucas' proposal, it should be possible to blame Jenkins within recheck comments. There's also another minor bug I encountered several times, and I'm unsure if it's already been fixed in 2.16. Have 2 different changes, A and B. If I write A's change ID in the commit message of B, then the UI will show that A is "needed-by" B, and this could lead to confusion especially if the dependency is the other way around, i.e. A depends-on B. And, BTW, thanks for your work on gerrit!
Daimona
Example A: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481549... Example B: https://gerrit.wikimedia.org/r/#/c/integration/config/+/481570/
Il giorno mar 29 gen 2019 alle ore 11:21 Lucas Werkmeister < lucas.werkmeister@wikimedia.de> ha scritto:
I wonder if it would be possible to allow comments with “recheck” commands? Often I want to do something like “recheck because CI failed due to Txxxx”, but if I send it as one review then it will not be recognized as a recheck. Triggering a recheck any time the word “recheck” appears anywhere in a review would probably cause too many false positives, but I think accepting any review beginning with that word could be a good middle ground. (I’m not sure if this would also be useful with other commands like “check experimental”.)
Am Di., 29. Jan. 2019 um 01:26 Uhr schrieb Paladox via Wikitech-l < wikitech-l@lists.wikimedia.org>:
Hi, what would you like to see in gerrit or improved? I've been working been working on developing a plugin that pull's in zuul's status into PolyGerrit. See the running demo at https://imgur.com/a/uBk2oxQ . Im
also
planning on adding "recheck" and "check experimental" as buttons to PolyGerrit's ui to improve CI. This will help new users who can recheck (and existing users that either forgot they can type this or haven't learned yet). Note that i cannot promise that anything suggested in this thread will be worked on, but i can try my best. See tasks https://phabricator.wikimedia.org/T214068 and https://phabricator.wikimedia.org/T214631 .
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Lucas Werkmeister Full Stack Developer
Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin Phone: +49 (0)30 219 158 26-0 https://wikimedia.de
Imagine a world in which every single human being can freely share in the sum of all knowledge. Help us to achieve our vision! https://spenden.wikimedia.de
Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207. _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l