Simetrical wrote:
On 8/31/07, brion@pobox.com brion@pobox.com wrote:
1 previously passing test(s) now FAILING! :( * <references> after <gallery> (bug 6164) [Introduced between 30-Aug-2007 07:15:18, 1.11alpha (r25303) and 31-Aug-2007 07:15:36, 1.11alpha (r25338)]
I think this was mainly r25335.
<div class="thumb" style="padding: 66px 0;width: 150px;"><a href="/wiki/Image:Foobar.jpg" title="Image:Foobar.jpg"><img src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" alt="" /></a></div>
<div class="thumb" style="padding: 66px 0;width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
Adds an extra <div style="margin-left: auto; margin-right: auto; width: 120px;"> (can't we use stylesheets for that? div.thumb div? or even div.thumb a, perhaps), an extra class="image" on the a element.
"div.thumb div" would break everything, so probably not advisable. Maybe you could have a special class just for this rule, but as you can see, I'm just replacing one style attribute with another that does the same thing in a more general case, so it's not a new issue.
If I had seen this before I committed it, I would have changed the expected output, like I did for the other ~30 parser tests I broke.
More interesting is this part:
-src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" +src="http://example.com/images/3/3a/Foobar.jpg"
Doesn't that mean this has changed galleries to serve all images raw instead of thumbnailed?
That's what you get if no thumbnailing method is available on the server the test runs on, it falls back to client-side scaling. I got a normal thumb URL when I tried it on my test install.
-- Tim Starling