-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 08/11/2018 06:48 PM, Brion Vibber wrote:
Second, probably related to that I'm seeing a failure in the code coverage calculations -- it's seeing some increased coverage on the parent process at least but seems to think it's returning a non-zero exit code somewhere, which marks the whole operation as a failure:
https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-pa
tch-docker/460/console
I
think your test and the tool are working properly, there just is an actual coverage drop:
+-------------------------------------+--------+--------+ | Filename | Old % | New % | +-------------------------------------+--------+--------+ | includes/QueueingForkController.php | 0 | 07.92 | | maintenance/Maintenance.php | 20.51 | 19.83 | +-------------------------------------+--------+--------+
If you look at the HTML report[1], all the new lines added to Maintenance.php are not covered by tests, which is decreasing coverage.
The tool currently reports a coverage drop if it drops in any file, which isn't necessary ideal, see [2].
[1] https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-patc h-docker/460/artifact/log/coverage.html [2] https://phabricator.wikimedia.org/T188687
- -- Legoktm