on both monitors i checked, 0.2 opacity is too low, plus I don't think it should apply to the border, just the header inside it, which also removes the need to restore it on click. What do you think?
function silentNoise( $commentPanel ) { // makes jenkins comments less prominent $commentPanel.find( '.commentPanelHeader' ).css( 'opacity', 0.6 ); }
On Wed, Apr 3, 2013 at 3:19 PM, Jon Robson jdlrobson@gmail.com wrote:
You'll need to reload the extension in chrome://extensions It purposely doesn't delete the comment lines - it just makes them invisible just in case you might want to see them. It's all one big hack so might be wrong but it works for me ;-)
On Wed, Apr 3, 2013 at 12:17 PM, Yuri Astrakhan <yastrakhan@wikimedia.org
wrote:
hehe, thanks! :), just pulled again, but, its broken a bit :(
https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it
deleted
comment lines, but apparently its just in indecipherable colors, until clicked
On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson jdlrobson@gmail.com wrote:
Yuri Great minds think alike ;-)
https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57...
On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan <
yastrakhan@wikimedia.org
wrote:
Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation
fails,
its ok to click to expand just that comment. Or maybe just expand the
last
jenkin-bot comment, but hide all the previous ones.
On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan <
yastrakhan@wikimedia.org
wrote:
This is awesome!!! Thanks Jon :) And no, I didn't look at the code,
too
scared :)
On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrobson@gmail.com
wrote:
I feel very dirty having done this but I made a chrome extension
that
autoexpands all comments and adds a comment count next to
unexpanded
older
patchsets.
The code's horrible but it works - feel free to try it out:
https://github.com/jdlrobson/gerrit-be-nice-to-me
I suspect the best long term solution might be to rewrite the
interface.
The fact it is so ajaxay makes enhancements hard unless someone
actually
wants to get to know and work on the gerrit codebase themselves...
On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z@mzmcbride.com
wrote:
> Christian Aistleitner wrote: > >while I do not want to discourage discussion of those items on > >wikitech-l, I nevertheless filed them in bugzilla, so we can
keep
> >track of the issues / solutions. > > This is wonderful. Thank you for filing these bugs, Christian.
I'll
take a > look at them now. > > MZMcBride > > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l >
-- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l