On Thu, Jun 26, 2008 at 2:43 PM, Simetrical Simetrical+wikilist@gmail.com wrote:
On Thu, Jun 26, 2008 at 2:34 PM, Bryan Tong Minh bryan.tongminh@gmail.com wrote:
It is. CentralAuthPlugin::updateUser (which is according to documentation called each login) always sets the local email to the global email.
That seems unnecessary. Perhaps it could be fixed? Especially if it's causing locking problems (although I'm not sure what it's contending with for the lock).
It's a todo on User::saveSettings: "@todo Only rarely do all these fields need to be set!"
Okay, so can we ditch the setting user_name to $mName, at least? The only thing that should legitimately be saving changes to user_name is RenameUser, and that doesn't use User::saveSettings, it does a direct query. Anything saving changes to user_name is going to want to do a whole bunch of direct queries, anyway. The only problem is if someone, somewhere, in some broken extension, actually called setName() followed by saveSettings() and expected it to *work* (which the name of the method totally doesn't suggest, anyway).
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
What if User::saveSettings() accepted an array of column names/values to put into the update? If it's left null, it would save all settings, keeping backward compatibility.
-Chad