On Mon, Feb 28, 2011 at 4:08 PM, Ashar Voultoiz hashar+wmf@free.fr wrote:
I noticed code review lagging a bit in trunk, which I was expecting since 1.17 have kept guru busy for the last month. When I started code reviewing in October or November 2010, I have spent hours and hours reviewing trivial revisions that mostly anyone could have marked ok.
Yeah, 1.17's kept a lot of us busy. Hopefully as the dust on the cluster begins to settle and the regressions are fixed we can get back into high gear for reviewing.
It's true while reviewing you notice a lot of trivial revisions like comment fixes, whitespace cleanup, spelling fixes and the like. The real answer to that is making CR happen often, so those are reviewed and cleaned out regularly.
In attempt to get more people to review the code, I have started marking my own trivial commits with the tag 'easy'. It would be a good way to start being confident in reviewing code if you have not yet tried :)
I really don't agree with this idea. Setting "ok" on a revision implies that the code is ok to run in production environments. While a comment change doesn't really matter, I don't like setting that precedence. In fact, this was the exact reason the "Sign-offs" feature was developed: to encourage people who are not reviewers to say "I've looked at this and it seems ok" or "I've tested this and confirmed that it works." That's actually a lot more useful.
-Chad