-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Simetrical wrote:
On Tue, Mar 25, 2008 at 12:18 AM, VasilievVV vasilvv@gmail.com wrote:
Yeah, I've already replaced it with Title::makeTitleSafe(). And I still can't understand why did Simetrical reverted r32229.
The documentation for Title::makeTitleSafe() says it accepts title keys only. r32229 added it in a place that was supposed to accept text forms, not just title keys.
These days pretty much everything should be accepting either spaces or underscores and normalizing input to the appropriate internal processing form.
If there are exceptions (and I'm sure there are), they ought to get fixed. :)
Title::makeTitle and Title::makeTitleSafe certainly will accept spaces; historically it was too error-prone to maintain a forced underscores-only input regimen.
- -- brion vibber (brion @ wikimedia.org)