On Mon, Aug 25, 2008 at 2:50 AM, dantman@svn.wikimedia.org wrote:
Revision: 39938 Author: dantman Date: 2008-08-25 06:50:31 +0000 (Mon, 25 Aug 2008)
Log Message:
Revert 39936 and 39935; This 'fix' is merely a bad workaround and creates more issues rather than simply fixing. A) Part of the Title class is being /duplicated/ meaning more bugs are going to show up when someone improves stuff inside Title and doesn't know stuff is duplicated here. B) This change breaks cases as $wgCaptialLinks is now a per-namespace array, not a boolean.
No it isn't, that patch hasn't been committed. The correct function call (once it's committed) will be MWNamespace::isCapitalized( $index ). Fwiw: running a title through Title::newFromText() eventually runs it through $title->secureAndSplit(), which does all kinds of fun normalization (including forced first-letter capitalization). Personally, I'd rather see _more_ of the logic for first-letter-case-sensitivity go there, rather than have $wgCapitalLinks floating around everywhere.
As to the original bug: I say "invalid" myself. Trailing spaces and leading spaces are _always_ trimmed. Thoughts on this?
-Chad