Why skip trying to find the location? If MW_INSTALL_PATH is already missing, what have we got to lose from trying to guess the location? The vast majority of people don't screw with the default structure, so it should be just fine.
-Chad
On Aug 24, 2009 11:20 AM, "dan nessett" dnessett@yahoo.com wrote:
--- On Sun, 8/23/09, Aryeh Gregor <Simetrical+wikilist@gmail.comSimetrical%2Bwikilist@gmail.com> wrote: > If they can run commands... Thanks for clarifying the situation. Given this information I suggest changing all code in command line utilities of the form:
$IP = getenv( 'MW_INSTALL_PATH' ); if ( $IP === false ) { $IP = dirname(__FILE__).'/../..'; } to:
$IP = getenv( 'MW_INSTALL_PATH' ); if ( $IP === false ) { echo "Error. The environmental variable MW_INSTALL_PATH must be set to the root of the MW distribution. Exiting.\n"; die(); }
This would eliminate file position dependent code from the command line utilities, making them easier to maintain (i.e., they can be moved in the distribution without breaking them).
Dan
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.w...