Hard deprecated = generates warnings if $wgEnableDevelopmentWarnings is on (which in turn cause unit tests to fail, as warnings are considered errors in a test). The code is still there and working for the moment.
-- Brian
On Monday, July 6, 2020, Jay R. Ashworth jra@baylink.com wrote:
<nerd type=jargon> I think you might be better calling that "removed"; the entire *point* of the jargon usage of 'deprecated' is "it's still there and working, but start moving off it soon, cause we're gonna remove it". </nerd>
----- Original Message -----
From: "Petr Pchelko" ppchelko@wikimedia.org To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Sent: Monday, July 6, 2020 4:18:34 PM Subject: [Wikitech-l] Hard deprecation of the Revision class
Hey all,
TLDR: your extension CI might break due to hard deprecation of Revision class.
Today a Gerrit change[1] has been merged, hard deprecating MediaWiki core Revision class. Loads of work has been done to prepare for this moment, mostly by a volunteer developer DannyS712 with code review support from almost every corner of the MediaWiki developer universe. You can judge the amount of work by the number of subtasks in the tracking ticket[2]
A lot of effort has been done to update all the WMF deployed extensions
and
some non-deployed ones to the new code, In accordance with stable interface policy deprecation section[3].
However
due to the gravity of a change, we might have missed some corner cases. Missed usages will not cause problems in production since the only consequence of using hard deprecated code is a log message, but some CI tests might start failing. If you find your tests failing, please replace all the usages of the Revision class according to 1.35 release notes, and your tests should start passing again. In case you’re having troubles doing it, please reach out to core platform team and we will try to help.
This is a huge milestone in decoupling MediaWiki core! We understand that this might cause some inconveniences, apologize for them and are hoping we can help with resolving any issues.
Cheers. Petr Pchelko
- https://gerrit.wikimedia.org/r/c/mediawiki/core/+/608845
- https://phabricator.wikimedia.org/T246284
- https://www.mediawiki.org/wiki/Stable_interface_policy#Deprecation
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- Jay R. Ashworth Baylink jra@baylink.com Designer The Things I Think RFC 2100 Ashworth & Associates http://www.bcp38.info 2000 Land Rover DII St Petersburg FL USA BCP38: Ask For It By Name! +1 727 647 1274
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l