Hi All,
Two quick parserTest diffs for your check-in consideration: 1) http://files.nickj.org/MediaWiki/coverage/parserTests.inc.diff.txt Adds the ability to test $wgRawHtml=true to parserTests and removes one duped line. 2) http://files.nickj.org/MediaWiki/coverage/parserTests.txt.diff.txt Adds some more tests, thereby incrementally increasing code coverage to 87.98 % Also adds a few tests that currently fail, where I'm not convinced totally convinced about the current behaviour (e.g. "Always escape literal '>' in output, not just after '<'", and "Don't fall for the self-closing div") - but as always please change the expected results if you don't agree.
Also, is there any chance we could delete the "getTemplateArgs" method from Parser.php ? There I was trying various template args in order to invoke it, so as to bring up the Code Coverage stats, and I just couldn't get it to happen. Upon checking, seems that's because this function is never called:
===================================================== root@bling:/var/www/hosts/mediawiki/wiki# grep -inr getTemplateArgs * includes/.svn/text-base/Parser.php.svn-base:2608: function getTemplateArgs( $argsString ) { includes/Parser.php:2608: function getTemplateArgs( $argsString ) { root@bling:/var/www/hosts/mediawiki/wiki# =====================================================
If that's correct, can we please kill it? ( I'm assuming of course it's a vestigial relic of something that was, rather than an evolving prototype of something to come ).
All the best, Nick.