On Sat, 2005-12-03 at 13:41 -0800, Brion Vibber wrote:
Evan Prodromou wrote:
I made a late checkin on the 1.4 branch today.
I've reverted it for the moment. Could you check it into the mainline development branch please?
Sure, but it should really go out for 1.4 final, as the hooks architecture is read-only without it (counter its documentation).
If it looks ok and doesn't break the actual called hook functions (or if it does, and we have some warning to fix them first), *then* go ahead check it into REL1_4.
I've tested every single one of the hook events, both with and without the Syslog sample extension. This was in the REL1_4 branch; I think it probably makes better sense to test in the 1.4 branch than with the HEAD branch (since that's what's actually going out), but I'll do that too.
~Evan