Since I'm the one with +2 at labs/tools/commons-mass-description and labs/tools/map-of-monuments, I've reviewed&merged the newest patch from l10n-bot, and abandoned the rest. Thanks for notifying me this way!
PS: Manual review detected should IMO cause an email notification... My review work is email-based, and I have little to no chance to actually notice I should review those patches.
Martin Urbanec
On Tue, 30 Apr 2019 at 19:28, James Forrester jforrester@wikimedia.org wrote:
On Tue, 30 Apr 2019 at 02:55, Sam Wilson sam@samwilson.id.au wrote:
Are these actually false positives? Because it looks like the error is mostly (or all?) "HTML detected. Manual review required", and so these shouldn't be automatically merged without human review.
Correct. Those patches are waiting for the project owner to manually review and merge them. All the older ones can be abandoned by the project owners.
Specifically, there are multiple outstanding i18n patches for crosswatch ( members < https://gerrit.wikimedia.org/r/admin/groups/c036413a343d9d7cadd6a9b51cd700dd...
, patches < https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcrosswatch+statu...
),
commons-mass-description (member https://gerrit.wikimedia.org/r/admin/groups/1524,members, patches < https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fcommons-mass-des...
),
and map-of-monuments (members https://gerrit.wikimedia.org/r/admin/groups/1522,members, patches < https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fmap-of-monuments...
).
J.
*James D. Forrester* (he/him http://pronoun.is/he or they/themself http://pronoun.is/they/.../themself) Wikimedia Foundation https://wikimediafoundation.org/ _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l