On 07/03/14 17:06, Antoine Musso wrote:
Le 07/03/2014 16:48, Bartosz Dziewoński a écrit :
On Fri, 07 Mar 2014 16:27:53 +0100, Antoine Musso hashar+wmf@free.fr wrote:
So a single -1 should prevent a change from being submitted until that -1 is lifted by addressing the person concern(s) or correcting him/her or whatever.
Note that such a rule never been followed by anyone, including by various WMF teams. You can easily find numerous examples, even if these searches are limited to only changesets where the -1 stuck on the last patchset.
https://gerrit.wikimedia.org/r/#/q/is:merged+label:Code-Review-1,n,z (this search seems to hang forever) https://gerrit.wikimedia.org/r/#/q/is:merged+label:Code-Review-1+project:med...
That is like ~10 changes per year on core, which suggest we attempt to get the -1 lifted before merging :-D
We do attempt to get it lifted, but this is not always feasible. Here, as in other cases, the issues were discussed and a good faith effort was put in to address them (most were indeed resolved), and what more can we really do? Even when a minority opinion cannot convince others that something is bad, they will not necessarily change their minds and agree that it is good, either.
Sometimes it does turn out they are right, but does that mean we should automatically stand down whenever a single person disagrees? They should to be able to show they are right, and if they cannot, then will the change not show it later if it comes to it?
Coming to a standstill over these achieves nothing.
-I